[GR-41675] Only require libmanagement_ext if it's actually needed. #5122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
approved these changes
Sep 30, 2022
Collaborator
zakkak
left a comment
zakkak
left a comment
There was a problem hiding this comment.
LGTM, although I don't really understand why we need to add management_ext twice in the first place.
fniephaus
reviewed
Oct 1, 2022
...vm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/JNIRegistrationManagementExt.java
Show resolved
Hide resolved
jerboaa
force-pushed
the
libmanagement_ext_awt_headless_fix_v2
branch
from
1024220 to
8522603
Compare
pejovica
reviewed
Oct 5, 2022
...vm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/jdk/JNIRegistrationManagementExt.java
Outdated
Show resolved
Hide resolved
On some systems/apps, libawt_headless gets pulled in. This currently brings in libmanagement_ext unconditionally. However, libmanagement_ext should only be present for linking iff com.sun.management.internal.OperatingSystemImpl class becomes reachable. Closes: oracle#5119
jerboaa
force-pushed
the
libmanagement_ext_awt_headless_fix_v2
branch
from
8522603 to
84c9266
Compare
pejovica
approved these changes
Oct 6, 2022
Collaborator
Author
|
Thanks for the reviews! |
Collaborator
Author
|
If somebody could help with getting it integrated, I'd appreciate it. |
Collaborator
Author
|
@fniephaus Could you please help getting this fix integrated? Thank you! |
Member
|
Sure, but I'm afraid this won't make it into 22.3. |
Collaborator
Author
That's fine. Thanks! |
Member
|
You got it! |
fniephaus
changed the title
Member
|
Internal PR is at #5195. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems/apps, libawt_headless gets pulled in. This currently brings in libmanagement_ext unconditionally. However, libmanagement_ext should only be present for linking iff
com.sun.management.internal.OperatingSystemImpl class becomes reachable. The fix is to only add
management_extas a dependency forawt_headlesswhen classOperatingSystemImplis actually reachable.Closes: #5119