Skip to content

parameterize optimizely unit tests with v4 datafile #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2017
Merged

parameterize optimizely unit tests with v4 datafile #123

merged 2 commits into from
Jul 7, 2017

Conversation

@wangjoshuah
Copy link
Contributor

@wangjoshuah wangjoshuah commented Jul 6, 2017

@optimizely/fullstack-devs

@optibot
Copy link

optibot commented Jul 6, 2017

Can one of the admins verify this patch?

@wangjoshuah wangjoshuah requested a review from aliabbasrizvi July 6, 2017 19:23
@wangjoshuah
Copy link
Contributor Author

wangjoshuah commented Jul 6, 2017

build

mikeproeng37
mikeproeng37 approved these changes Jul 7, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wangjoshuah wangjoshuah merged commit b068572 into master Jul 7, 2017
@wangjoshuah wangjoshuah deleted the josh.wang/parameterize_OptimizelyTest_with_v4 branch July 7, 2017 18:33
@thomaszurkan-optimizely thomaszurkan-optimizely mentioned this pull request Nov 7, 2018
Merged
This was referenced Dec 6, 2018
Merged
Merged
@thomaszurkan-optimizely thomaszurkan-optimizely mentioned this pull request Jan 10, 2019
Closed
@msohailhussain msohailhussain mentioned this pull request Jul 1, 2019
Merged
@mnoman09 mnoman09 mentioned this pull request Jul 8, 2019
Merged
@juancarlostong juancarlostong mentioned this pull request Feb 7, 2020
Merged
@mikecdavis mikecdavis mentioned this pull request Mar 27, 2020
Closed
This was referenced Mar 31, 2020
Closed
Merged
Closed
This was referenced Jul 7, 2020
Merged
Merged
@umermansoor umermansoor mentioned this pull request Aug 3, 2020
Merged
@thomaszurkan-optimizely thomaszurkan-optimizely mentioned this pull request Sep 2, 2020
Closed
This was referenced Sep 10, 2020
Merged
Merged
@mnoman09 mnoman09 mentioned this pull request Sep 23, 2020
Closed
@umermansoor umermansoor mentioned this pull request Oct 25, 2020
Merged
@jaeopt jaeopt mentioned this pull request Dec 11, 2020
Closed
@mnoman09 mnoman09 mentioned this pull request Mar 24, 2022
Merged
@mnoman09 mnoman09 mentioned this pull request Jun 8, 2022
Merged
This was referenced Jun 17, 2022
Closed
Merged
@mnoman09 mnoman09 mentioned this pull request Jul 19, 2022
Closed
@zashraf1985 zashraf1985 mentioned this pull request Oct 27, 2022
Closed
@jaeopt jaeopt mentioned this pull request Jun 7, 2023
Closed
@muzahidul-opti muzahidul-opti mentioned this pull request Jan 28, 2025
Merged
This was referenced Feb 13, 2025
Merged
Merged
@muzahidul-opti muzahidul-opti mentioned this pull request May 28, 2025
Merged
@esrakartalOpt esrakartalOpt mentioned this pull request Jul 30, 2025
Closed
This was referenced Aug 25, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vraja2 vraja2 Awaiting requested review from vraja2

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangjoshuah @optibot @mikeproeng37