Skip to content

ci: hook fps on travis #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2020
Merged

ci: hook fps on travis #382

merged 3 commits into from
Jul 16, 2020

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 7, 2020 •
edited by msohailhussain
Loading

Summary

This PR hooks Fullstack Prod Suite build on Travis.

Test plan

Added FPS Check which should be passed

@oakbani oakbani marked this pull request as ready for review July 7, 2020 14:19
@oakbani oakbani requested a review from a team as a code owner July 7, 2020 14:19
@oakbani oakbani removed their assignment Jul 7, 2020
@oakbani oakbani requested a review from msohailhussain July 7, 2020 14:19
@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1458

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.484%
Totals Coverage Status
Change from base Build 1454: 0.0%
Covered Lines: 3957
Relevant Lines: 4422
💛 - Coveralls

aliabbasrizvi
aliabbasrizvi approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Please clean up summary before merging.

msohailhussain
msohailhussain approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 16f144d into master Jul 16, 2020
@mikeproeng37 mikeproeng37 deleted the oakbani/hook-fps branch July 16, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 16 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@oakbani @coveralls @aliabbasrizvi @msohailhussain @mikeproeng37 @optimizely-codereview-bot