Skip to content

ci: add source clear as a separate stage #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2020
Merged

ci: add source clear as a separate stage #385

merged 1 commit into from
Jul 14, 2020

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Jul 13, 2020 •
edited
Loading

Summary

Adds a separate stage for Source Clear, to only run on cron builds.

Test plan

Issues

@coveralls
Copy link

coveralls commented Jul 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1453

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.484%
Totals Coverage Status
Change from base Build 1451: 0.0%
Covered Lines: 3957
Relevant Lines: 4422
💛 - Coveralls

@oakbani oakbani marked this pull request as ready for review July 13, 2020 11:27
@oakbani oakbani requested a review from a team as a code owner July 13, 2020 11:27
@oakbani oakbani requested a review from mikeproeng37 July 13, 2020 11:27
@oakbani oakbani removed their assignment Jul 13, 2020
mikeproeng37
mikeproeng37 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 04b4e95 into master Jul 14, 2020
@mikeproeng37 mikeproeng37 deleted the oakbani/src-clr branch July 14, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🤖 8 hrs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oakbani @coveralls @mikeproeng37 @optimizely-codereview-bot