OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 #4982

isabella-janssen · 2025-04-10T17:41:42Z

Closes: OCPBUGS-54872

- What I did
This updates the part of generateAndApplyMachineConfigNodes that create's an MCN's Status.PinnedImageSets object to only set LastFailedGeneration to a real (non-default) value. This is needed due to a validation change being made for the V1 MCN API (ref).

- How to verify it
What to look for:

Confirming functionality is still working as intended with the new validation rules, including confirmation that no new errors are reported.
Make sure "generation" values are never 0.

Launch a cluster using the changes in this PR and the dummy API PR mocking the validation rule updates being imposed for the MCN V1 API.

launch 4.19.0-0,openshift/api#2272,openshift/machine-config-operator#4982 aws,techpreview

Make sure MCN is still behaving as expected on valid MC application.
a. MCN should transition through conditions.
b. ObservedGeneration value should increment.
c. Observed functionality should overall be consistent with before this change.

Example MC

apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: 99-worker-testfile
spec:
  config:
    ignition:
      version: 3.2.0
    storage:
      files:
      - contents:
          source: data:,hello%20world%0A
        mode: 420
        path: /home/core/test

Make sure PIS status is being reported correctly for a valid PIS application.
a. Note that LastFailedGeneration should not report a value of 0.

Example Valid PIS

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  name: test-pinned
  labels:
    machineconfiguration.openshift.io/role: "worker"
spec:
  pinnedImages:
   - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
   - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b

$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
  Pinned Image Sets:
    Current Generation:  1
    Desired Generation:  1
    Name:                test-pinned
....

Make sure PIS status is being reported correctly for an invalid PIS application.
a. Note that LastFailedGeneration should reflect that the PIS application has failed and LastFailedGenerationError should be populated.

Example Invalid PIS

apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  name: test-pinned
  labels:
    machineconfiguration.openshift.io/role: "worker"
spec:
  pinnedImages:
   - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
   - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b

$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
  Pinned Image Sets:
    Desired Generation:            2
    Last Failed Generation:        2
    Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
    Name:                          test-pinned
....

- Description for the changelog
OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0

openshift-ci · 2025-04-10T17:42:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-04-10T19:42:25Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-54872, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

TODO: Note that this builds on top of #4962 and will need to be rebased after it is merged.

Closes: OCPBUGS-54872

- What I did
This updates the part of generateAndApplyMachineConfigNodes that create's an MCN's Status.PinnedImageSets object to only set LastFailedGeneration to a real (non-default) value. This is needed due to a validation change being made for the V1 MCN API (ref).

- How to verify it
What to look for:

Confirming functionality is still working as intended with the new validation rules, including confirmation that no new errors are reported.

Make sure "generation" values are never 0.

Launch a cluster using the changes in this PR and the dummy API PR mocking the validation rule updates being imposed for the MCN V1 API.
launch 4.19.0-0,openshift/api#2272,openshift/machine-config-operator#4982 aws,techpreview
Make sure MCN is still behaving as expected on valid MC application.
a. MCN should transition through conditions.
b. ObservedGeneration value should increment.
c. Observed functionality should overall be consistent with before this change.
Example MC
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: worker
 name: 99-worker-testfile
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:,hello%20world%0A
       mode: 420
       path: /home/core/test
Make sure PIS status is being reported correctly for a valid PIS application.
a. Note that LastFailedGeneration should not report a value of 0.
Example Valid PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Current Generation:  1
   Desired Generation:  1
   Name:                test-pinned
....
Make sure PIS status is being reported correctly for an invalid PIS application.
a. Note that LastFailedGeneration should reflect that the PIS application has failed and LastFailedGenerationError should be populated.
Example PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned
....
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-10T21:55:30Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-54872, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: OCPBUGS-54872

- What I did
This updates the part of generateAndApplyMachineConfigNodes that create's an MCN's Status.PinnedImageSets object to only set LastFailedGeneration to a real (non-default) value. This is needed due to a validation change being made for the V1 MCN API (ref).

- How to verify it
What to look for:

Confirming functionality is still working as intended with the new validation rules, including confirmation that no new errors are reported.

Make sure "generation" values are never 0.

Launch a cluster using the changes in this PR and the dummy API PR mocking the validation rule updates being imposed for the MCN V1 API.
launch 4.19.0-0,openshift/api#2272,openshift/machine-config-operator#4982 aws,techpreview
Make sure MCN is still behaving as expected on valid MC application.
a. MCN should transition through conditions.
b. ObservedGeneration value should increment.
c. Observed functionality should overall be consistent with before this change.
Example MC
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: worker
 name: 99-worker-testfile
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:,hello%20world%0A
       mode: 420
       path: /home/core/test
Make sure PIS status is being reported correctly for a valid PIS application.
a. Note that LastFailedGeneration should not report a value of 0.
Example Valid PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Current Generation:  1
   Desired Generation:  1
   Name:                test-pinned
....
Make sure PIS status is being reported correctly for an invalid PIS application.
a. Note that LastFailedGeneration should reflect that the PIS application has failed and LastFailedGenerationError should be populated.
Example PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned
....
- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ptalgulk01 · 2025-04-11T13:13:08Z

Pre-merge verified:
Verified using IPI based AWS cluster 4.19 TechPreview enabled.

Before applying any MC/PIS following condition was seen in MCN for master & worker pool

$ oc describe machineconfignodes ip-10-0-15-48.us-east-2.compute.internal | tail -n 10
    Last Transition Time:  2025-04-11T05:00:14Z
    Message:               All is good
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsDegraded
  Config Version:
    Current:            rendered-master-48ea8c8dd98876f60b585a16ada3d0db
    Desired:            rendered-master-48ea8c8dd98876f60b585a16ada3d0db
  Observed Generation:  5
Events:                 

$ oc describe machineconfignodes ip-10-0-69-189.us-east-2.compute.internal | tail -n 10
    Last Transition Time:  2025-04-11T05:01:47Z
    Message:               All is good
    Reason:                AsExpected
    Status:                False
    Type:                  PinnedImageSetsDegraded
  Config Version:
    Current:            rendered-worker-2ab2379ed6bbc6fbffbe53ffacc2de00
    Desired:            rendered-worker-2ab2379ed6bbc6fbffbe53ffacc2de00
  Observed Generation:  4
Events:

Applied the MC described in PR description on master & worker pool
During the MCN update the ObservedGeneration count was increased

$ oc get machineconfignode ip-10-0-15-48.us-east-2.compute.internal -o yaml | tail -n 10
    type: Uncordoned
  - lastTransitionTime: "2025-04-11T05:00:14Z"
    message: All is good
    reason: AsExpected
    status: "False"
    type: PinnedImageSetsDegraded
  configVersion:
    current: rendered-master-48ea8c8dd98876f60b585a16ada3d0db
    desired: rendered-master-475d88e145caaa28698a83b8a5a00bdf
  observedGeneration: 6

$ oc get machineconfignode ip-10-0-69-189.us-east-2.compute.internal -o yaml| tail -n 10
    type: Uncordoned
  - lastTransitionTime: "2025-04-11T07:46:02Z"
    message: All is good
    reason: AsExpected
    status: "False"
    type: PinnedImageSetsDegraded
  configVersion:
    current: rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
    desired: rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
  observedGeneration: 5

Applied the valid PIS

Example

oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: tc-80334-worker-pinned-images
spec:
  pinnedImages:
  - name: "quay.io/openshifttest/busybox@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
  - name: quay.io/openshifttest/alpine@sha256:be92b18a369e989a6e86ac840b7f23ce0052467de551b064796d67280dfa06d5
EOF
pinnedimageset.machineconfiguration.openshift.io/tc-80334-worker-pinned-images created

- In MCN following was observed. Verifying the no last failed generation or last failed generation error should show in the MCN.

$ oc describe machineconfignodes ip-10-0-64-82.us-east-2.compute.internal | tail -n 10 
....
    Type:                  PinnedImageSetsDegraded
  Config Version:
    Current:            rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
    Desired:            rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
  Observed Generation:  3
  Pinned Image Sets:
    Current Generation:  1
    Desired Generation:  1
    Name:                tc-80334-worker-pinned-images
Events:

- Applied the invalid PIS

Example

oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
  labels:
    machineconfiguration.openshift.io/role: worker
  name: pinned-bad-image-tc-73361
spec:
  pinnedImages:
  - name: "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
EOF
pinnedimageset.machineconfiguration.openshift.io/pinned-bad-image-tc-73361 created

- In MCN for in-valid PIS, both the last failed generation and last failed generation error should show in Pinned Image Sets field.

$ oc describe machineconfignodes ip-10-0-64-82.us-east-2.compute.internal | tail -n 10 
oc describe machineconfignodes ip-10-0-23-169.us-east-2.compute.internal | tail -n 10
  Config Version:
    Current:            rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
    Desired:            rendered-worker-dcfc7ccdb9b4b89247cedd00091124a6
  Observed Generation:  3
  Pinned Image Sets:
    Desired Generation:            1
    Last Failed Generation:        1
    Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019": exit status 125
    Name:                          pinned-bad-image-tc-73361
Events:

Adding QE approved label
/label qe-approved

djoshy · 2025-04-11T13:23:39Z

/lgtm

Thanks for the fix!

openshift-ci · 2025-04-11T13:24:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

isabella-janssen · 2025-04-11T13:58:46Z

/retest-required

openshift-ci-robot · 2025-04-11T16:12:10Z

/retest-required

Remaining retests: 0 against base HEAD 88b9bb6 and 2 for PR HEAD 0656eb0 in total

openshift-ci · 2025-04-11T18:36:48Z

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`0656eb0`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-upgrade-out-of-change	`0656eb0`	link	false	`/test e2e-aws-ovn-upgrade-out-of-change`
ci/prow/e2e-gcp-op-ocl	`0656eb0`	link	false	`/test e2e-gcp-op-ocl`
ci/prow/e2e-agent-compact-ipv4	`0656eb0`	link	false	`/test e2e-agent-compact-ipv4`
ci/prow/e2e-azure-ovn-upgrade-out-of-change	`0656eb0`	link	false	`/test e2e-azure-ovn-upgrade-out-of-change`
ci/prow/bootstrap-unit	`0656eb0`	link	false	`/test bootstrap-unit`
ci/prow/e2e-gcp-op-techpreview	`0656eb0`	link	false	`/test e2e-gcp-op-techpreview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-04-11T18:42:00Z

@isabella-janssen: Jira Issue OCPBUGS-54872: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#4982

Jira Issue OCPBUGS-54872 has been moved to the MODIFIED state.

In response to this:

Closes: OCPBUGS-54872

- What I did
This updates the part of generateAndApplyMachineConfigNodes that create's an MCN's Status.PinnedImageSets object to only set LastFailedGeneration to a real (non-default) value. This is needed due to a validation change being made for the V1 MCN API (ref).

- How to verify it
What to look for:

Confirming functionality is still working as intended with the new validation rules, including confirmation that no new errors are reported.

Make sure "generation" values are never 0.

Launch a cluster using the changes in this PR and the dummy API PR mocking the validation rule updates being imposed for the MCN V1 API.
launch 4.19.0-0,openshift/api#2272,openshift/machine-config-operator#4982 aws,techpreview
Make sure MCN is still behaving as expected on valid MC application.
a. MCN should transition through conditions.
b. ObservedGeneration value should increment.
c. Observed functionality should overall be consistent with before this change.
Example MC
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
 labels:
   machineconfiguration.openshift.io/role: worker
 name: 99-worker-testfile
spec:
 config:
   ignition:
     version: 3.2.0
   storage:
     files:
     - contents:
         source: data:,hello%20world%0A
       mode: 420
       path: /home/core/test
Make sure PIS status is being reported correctly for a valid PIS application.
a. Note that LastFailedGeneration should not report a value of 0.
Example Valid PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e
  - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Current Generation:  1
   Desired Generation:  1
   Name:                test-pinned
....
Make sure PIS status is being reported correctly for an invalid PIS application.
a. Note that LastFailedGeneration should reflect that the PIS application has failed and LastFailedGenerationError should be populated.
Example Invalid PIS
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
 name: test-pinned
 labels:
   machineconfiguration.openshift.io/role: "worker"
spec:
 pinnedImages:
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079
  - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b
$ oc apply -f <pis-file>
$ oc describe machineconfignode/<node-name>
...
Status:
...
 Pinned Image Sets:
   Desired Generation:            2
   Last Failed Generation:        2
   Last Failed Generation Error:  failed to execute podman manifest inspect for "quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079": exit status 125
   Name:                          test-pinned
....
- Description for the changelog
OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-04-11T22:01:58Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202504112112.p0.gc7c2314.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025

isabella-janssen marked this pull request as ready for review April 10, 2025 19:39

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025

openshift-ci bot requested review from cheesesashimi and djoshy April 10, 2025 19:39

isabella-janssen changed the title ~~(Not ready for review): OCPBUGS-54872~~ OCPBUGS-54872: Make sure generation values in MCN do not have a value of 0 Apr 10, 2025

openshift-ci bot requested a review from sergiordlr April 10, 2025 19:42

isabella-janssen changed the title ~~OCPBUGS-54872: Make sure generation values in MCN do not have a value of 0~~ OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 Apr 10, 2025

isabella-janssen mentioned this pull request Apr 10, 2025

DO NOT REVIEW: For testing openshift/api#2272

Closed

isabella-janssen force-pushed the ocpbugs-54872 branch from c434a93 to 34e6c9c Compare April 10, 2025 21:55

upgrade monitor: only set LastFailedGeneration when it is non-zero

0656eb0

isabella-janssen force-pushed the ocpbugs-54872 branch from ed4e1a9 to 0656eb0 Compare April 10, 2025 22:28

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 11, 2025

openshift-ci bot assigned djoshy Apr 11, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025

isabella-janssen mentioned this pull request Apr 11, 2025

OCPBUGS-54592: Only populate LastFailedGeneration & LastFailedGenerationError on PIS failure #4983

Merged

openshift-merge-bot bot merged commit c7c2314 into openshift:main Apr 11, 2025
10 of 17 checks passed

isabella-janssen deleted the ocpbugs-54872 branch April 11, 2025 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 #4982

OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 #4982

Uh oh!

isabella-janssen commented Apr 10, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Apr 10, 2025

Uh oh!

openshift-ci-robot commented Apr 10, 2025

Uh oh!

openshift-ci-robot commented Apr 10, 2025

Uh oh!

ptalgulk01 commented Apr 11, 2025 •

edited

Loading

Uh oh!

djoshy commented Apr 11, 2025

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

isabella-janssen commented Apr 11, 2025

Uh oh!

openshift-ci-robot commented Apr 11, 2025

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2025

Uh oh!

openshift-bot commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 #4982

OCPBUGS-54872: Make sure generation fields in MCN do not have a value of 0 #4982

Uh oh!

Conversation

isabella-janssen commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 10, 2025

Uh oh!

openshift-ci-robot commented Apr 10, 2025

Uh oh!

openshift-ci-robot commented Apr 10, 2025

Uh oh!

ptalgulk01 commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djoshy commented Apr 11, 2025

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

isabella-janssen commented Apr 11, 2025

Uh oh!

openshift-ci-robot commented Apr 11, 2025

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2025

Uh oh!

openshift-bot commented Apr 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isabella-janssen commented Apr 10, 2025 •

edited

Loading

ptalgulk01 commented Apr 11, 2025 •

edited

Loading