Skip to content

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Apr 10, 2025

This is a dummy PR to test some changes in openshift/machine-config-operator#4982 that will impact the MCN API.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview a29d116 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift a29d116 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade a29d116 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-techpreview a29d116 link true /test e2e-aws-serial-techpreview
ci/prow/minor-e2e-upgrade-minor a29d116 link true /test minor-e2e-upgrade-minor
ci/prow/verify a29d116 link true /test verify
ci/prow/e2e-aws-serial a29d116 link true /test e2e-aws-serial
ci/prow/verify-client-go a29d116 link true /test verify-client-go

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen
Copy link
Member Author

/close

Closing since I am done testing off this PR.

@openshift-ci openshift-ci bot closed this May 1, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2025

@isabella-janssen: Closed this PR.

In response to this:

/close

Closing since I am done testing off this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen isabella-janssen deleted the update-mcn-generation-validation branch May 15, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant