-
Notifications
You must be signed in to change notification settings - Fork 457
OCPBUGS-54592: Only populate LastFailedGeneration & LastFailedGenerationError on PIS failure
#4983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-54592: Only populate LastFailedGeneration & LastFailedGenerationError on PIS failure
#4983
Conversation
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-54592, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/jira refresh |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-54592, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…onError on PIS failure
fb7a6e8 to
8262eda
Compare
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-54592, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Holding for QE. |
|
Pre-merge verified:
$ oc describe machineconfignode ci-ln-wkzm86b-72292-8fnpn-worker-c-z9w8n | tail -n 10
Last Transition Time: 2025-04-21T06:58:38Z
Message: All is good
Reason: AsExpected
Status: False
Type: PinnedImageSetsDegraded
Config Version:
Current: rendered-worker-56e0a8f5585ffca778ea327471a3fb69
Desired: rendered-worker-56e0a8f5585ffca778ea327471a3fb69
Observed Generation: 4
Events:
$ oc describe machineconfignode ci-ln-wkzm86b-72292-8fnpn-worker-c-z9w8n | tail -n 10
Last Transition Time: 2025-04-21T06:58:38Z
Message: All is good
Reason: AsExpected
Status: False
Type: PinnedImageSetsDegraded
Config Version:
Current: rendered-worker-56e0a8f5585ffca778ea327471a3fb69
Desired: rendered-worker-f4bbd63607a0a44cbdf3282054f14d5f
Observed Generation: 5
Events:
Exampleoc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: worker
name: pinned-bad-image-tc-73361
spec:
pinnedImages:
- name: "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
EOF
pinnedimageset.machineconfiguration.openshift.io/pinned-bad-image-tc-73361 created
$ oc describe machineconfignode ci-ln-wkzm86b-72292-8fnpn-worker-c-z9w8n | tail -n 10
Config Version:
Current: rendered-worker-f4bbd63607a0a44cbdf3282054f14d5f
Desired: rendered-worker-f4bbd63607a0a44cbdf3282054f14d5f
Observed Generation: 5
Pinned Image Sets:
Desired Generation: 1
Last Failed Generation: 1
Last Failed Generation Error: failed to execute podman manifest inspect for "quay.io/openshiftfake/fakeimage@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019": exit status 125
Name: pinned-bad-image-tc-73361
Events:
4. Valid PIS
Exampleoc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: worker
name: tc-80334-worker-pinned-images
spec:
pinnedImages:
- name: "quay.io/openshifttest/busybox@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
- name: quay.io/openshifttest/alpine@sha256:be92b18a369e989a6e86ac840b7f23ce0052467de551b064796d67280dfa06d5
EOF
pinnedimageset.machineconfiguration.openshift.io/tc-80334-worker-pinned-images created
$ oc describe machineconfignode ci-ln-wkzm86b-72292-8fnpn-worker-c-z9w8n | tail -n 10
Config Version:
Current: rendered-worker-f4bbd63607a0a44cbdf3282054f14d5f
Desired: rendered-worker-f4bbd63607a0a44cbdf3282054f14d5f
Observed Generation: 5
Pinned Image Sets:
Current Generation: 1
Desired Generation: 1
Name: tc-80334-worker-pinned-images
Events:
/label qe-approved |
|
/unhold |
|
/retest-required |
|
/retest-required |
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e9c0b18
into
openshift:main
|
@isabella-janssen: Jira Issue OCPBUGS-54592: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-54592 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
|
/cherry-pick release-4.18 |
|
@isabella-janssen: #4983 failed to apply on top of branch "release-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes: OCPBUGS-54592
- What I did
This refactors some code originally written in #4982 to address OCPBUGS-54872. Due to the overlap of OCPBUGS-54592 (this PR's intended target) and OCPBUGS-54872 (fixed previously), no other code changes were required.
- How to verify it
LastFailedGenerationorLastFailedGenerationErrorvalue should be populated.Example Valid PIS
apiVersion: machineconfiguration.openshift.io/v1 kind: PinnedImageSet metadata: name: test-pinned labels: machineconfiguration.openshift.io/role: "worker" spec: pinnedImages: - name: quay.io/openshift-release-dev/ocp-release@sha256:513cf1028aa1a021fa73d0601427a0fbcf6d212b88aaf9d76d4e4841a061e44e - name: quay.io/openshift-release-dev/ocp-release@sha256:61eae2d261e54d1b8a0e05f6b5326228b00468364563745eed88460af04f909bLastFailedGenerationandLastFailedGenerationErrorvalue should be populated.Example Invalid PIS
apiVersion: machineconfiguration.openshift.io/v1 kind: PinnedImageSet metadata: name: test-pinned labels: machineconfiguration.openshift.io/role: "worker" spec: pinnedImages: - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:65d3a308767b1773b6e3ead2ec1bcae499dde6ef085753d7e20e685f78841079 - name: quay.io/rh-ee-ijanssen/machine-config-operator@sha256:fd3692eff21338e900a244dfe62152c959b84d73f2dd4503893de0f3fae61b0b- Description for the changelog
OCPBUGS-54592: Only populate LastFailedGeneration & LastFailedGenerationError values in MCN on PIS failure