Skip to content

Promote BYO OIDC features #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Promote BYO OIDC features #2454

merged 1 commit into from
Oct 1, 2025

Conversation

@everettraven
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@everettraven everettraven mentioned this pull request Aug 18, 2025
Closed
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 18, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k August 18, 2025 15:31
JoelSpeed
JoelSpeed reviewed Aug 19, 2025
View reviewed changes
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

3 similar comments
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@everettraven
promote BYO OIDC features
bee65eb 
Signed-off-by: Bryce Palmer <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@everettraven everettraven mentioned this pull request Sep 11, 2025
Closed
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven everettraven mentioned this pull request Sep 16, 2025
Merged
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

6 similar comments
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@liouk
Copy link
Member

liouk commented Sep 23, 2025

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@liouk
Copy link
Member

liouk commented Sep 24, 2025

/test verify-feature-promotion

@everettraven everettraven changed the title WIP: Promote BYO OIDC features Promote BYO OIDC features Sep 24, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025
@liouk
Copy link
Member

liouk commented Sep 25, 2025

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

2 similar comments
@liouk
Copy link
Member

liouk commented Sep 29, 2025

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/retest-required

@dgoodwin
Copy link
Contributor

/test verify-feature-promotion

I think you might have crept up overnight

@dgoodwin
Copy link
Contributor

/override ci/prow/verify-feature-promotion

One test is one failure away from passing, due to the infra issues in aws CI.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-feature-promotion

One test is one failure away from passing, due to the infra issues in aws CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@everettraven
Copy link
Contributor Author

/retest-required

@everettraven
Copy link
Contributor Author

/verified by verify-feature-promotion

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 30, 2025
@openshift-ci-robot
Copy link

@everettraven: This PR has been marked as verified by verify-feature-promotion.

In response to this:

/verified by verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@openshift-ci-robot
Copy link

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@everettraven
Copy link
Contributor Author

/retest-required

@sdodson
Copy link
Member

sdodson commented Sep 30, 2025

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7f24529 and 2 for PR HEAD bee65eb in total

@liouk
Copy link
Member

liouk commented Oct 1, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa7b372 and 1 for PR HEAD bee65eb in total

@sdodson
Copy link
Member

sdodson commented Oct 1, 2025

/override ci/prow/verify-feature-promotion ci/prow/e2e-aws-ovn ci/prow/e2e-aws-ovn-hypershift ci/prow/e2e-aws-ovn-hypershift-conformance ci/prow/e2e-aws-ovn-techpreview ci/prow/e2e-aws-serial-1of2 ci/prow/e2e-aws-serial-2of2 ci/prow/e2e-aws-serial-techpreview-1of2 ci/prow/e2e-aws-serial-techpreview-2of2 ci/prow/e2e-azure ci/prow/e2e-gcp ci/prow/e2e-upgrade ci/prow/e2e-upgrade-out-of-change ci/prow/minor-e2e-upgrade-minor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-1of2, ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-1of2, ci/prow/e2e-aws-serial-techpreview-2of2, ci/prow/e2e-azure, ci/prow/e2e-gcp, ci/prow/e2e-upgrade, ci/prow/e2e-upgrade-out-of-change, ci/prow/minor-e2e-upgrade-minor, ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-feature-promotion ci/prow/e2e-aws-ovn ci/prow/e2e-aws-ovn-hypershift ci/prow/e2e-aws-ovn-hypershift-conformance ci/prow/e2e-aws-ovn-techpreview ci/prow/e2e-aws-serial-1of2 ci/prow/e2e-aws-serial-2of2 ci/prow/e2e-aws-serial-techpreview-1of2 ci/prow/e2e-aws-serial-techpreview-2of2 ci/prow/e2e-azure ci/prow/e2e-gcp ci/prow/e2e-upgrade ci/prow/e2e-upgrade-out-of-change ci/prow/minor-e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bfcb56b into openshift:master Oct 1, 2025
28 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven everettraven mentioned this pull request Oct 1, 2025
Open
4 tasks
This was referenced Oct 2, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dgoodwin dgoodwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@everettraven @liouk @dgoodwin @openshift-ci-robot @sdodson @JoelSpeed @openshift-merge-robot