Skip to content

Add auth operator OIDC presubmit for Default featureset #69918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2025
Merged

Add auth operator OIDC presubmit for Default featureset #69918

merged 2 commits into from
Oct 15, 2025

Conversation

@liouk
Copy link
Member

@liouk liouk commented Oct 2, 2025

Since the ExternalOIDC features have been promoted to GA in 4.21, we can now run the OIDC presubmits on a default cluser profile instead of TPNU.

As a side change, this PR updates the timeout of the OIDC presubmits to match the one configured on the test side.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 2, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 2, 2025
@liouk liouk marked this pull request as ready for review October 2, 2025 13:54
@openshift-ci openshift-ci bot requested review from droslean and ibihim October 2, 2025 13:55
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liouk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-authentication-operator-master-e2e-oidc openshift/cluster-authentication-operator presubmit Presubmit changed
pull-ci-openshift-cluster-authentication-operator-release-4.21-e2e-oidc openshift/cluster-authentication-operator presubmit Presubmit changed
pull-ci-openshift-cluster-authentication-operator-release-4.20-e2e-oidc-techpreview openshift/cluster-authentication-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-authentication-operator-release-4.21-e2e-oidc-techpreview openshift/cluster-authentication-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-authentication-operator-master-e2e-oidc-techpreview openshift/cluster-authentication-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@liouk liouk changed the title WIP: Move OIDC presubmits from TPNU to Default Add auth operator OIDC presubmit for Default featureset Oct 2, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@liouk
Copy link
Member Author

liouk commented Oct 2, 2025

/pj-rehearse pull-ci-openshift-cluster-authentication-operator-master-e2e-oidc

@openshift-ci-robot
Copy link
Contributor

@liouk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

everettraven
everettraven approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liouk
Copy link
Member Author

liouk commented Oct 3, 2025

Rehearsals ack is blocked by openshift/cluster-authentication-operator#797.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@liouk
Copy link
Member Author

liouk commented Oct 14, 2025

/pj-rehearse pull-ci-openshift-cluster-authentication-operator-master-e2e-oidc

@openshift-ci-robot
Copy link
Contributor

@liouk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@liouk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@everettraven: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 14, 2025
@liouk
Copy link
Member Author

liouk commented Oct 15, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f01ab83 into openshift:master Oct 15, 2025
16 checks passed
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
@liouk @abhay-nutanix
Add auth operator OIDC presubmit for Default featureset (openshift#69918
6b358c4 
)

* cao/oidc: increase job timeout to 4h to match test config

* cao/oidc: add oidc job for the default cluster profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droslean droslean Awaiting requested review from droslean

@ibihim ibihim Awaiting requested review from ibihim

1 more reviewer

@everettraven everettraven everettraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@everettraven everettraven

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liouk @openshift-ci-robot @everettraven @openshift-merge-robot