-
Notifications
You must be signed in to change notification settings - Fork 576
[release-4.20] Promote BYO OIDC features #2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.20
Are you sure you want to change the base?
Conversation
|
Hello @liouk! Some important instructions when contributing to openshift/api: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This should not merge until the 4.20 branch is open for z-stream backports. /hold |
|
/assign |
|
/test verify-feature-promotion |
2 similar comments
|
/test verify-feature-promotion |
|
/test verify-feature-promotion |
|
/retest-required |
|
Though there were still some Required jobs failing, I anyway pre-merge tested this PR + openshift/cluster-authentication-operator#802 together with In a fresh env of cluster-bot payload 1, configured external oidc with Entra ID, pre-upgrade related tests passed including oc / console interactive logins, extra / uid checks, clusterversion/version and authentication.config/cluster and co/authentication's .status against their respecitve Jira bugs et al. So adding /verified label: I didn't yet have chance to cover testing 4.19 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc, also didn't test 4.20.0 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc. Because I had tested "4.21-nightly-payload -> upgrade to 4.21-external-oidc-GA-clusterbot-payload -> configure external oidc" without issue, I believe same confidence. |
|
@xingxingxia: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test verify-feature-promotion |
|
@liouk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a manual regeneration and backport of #2454.
Respective approved SBAR: https://docs.google.com/presentation/d/1MrqVU10UYBHNvCu5XrybHejHcqLRf1zsedCYv1hlZVQ/edit?slide=id.g37f5a0492ea_0_0#slide=id.g37f5a0492ea_0_0