Skip to content

Conversation

@liouk
Copy link
Member

@liouk liouk commented Oct 2, 2025

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

Hello @liouk! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liouk liouk changed the title WIP: [release-4.20] Promote BYO OIDC features [release-4.20] Promote BYO OIDC features Oct 2, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@everettraven
Copy link
Contributor

This should not merge until the 4.20 branch is open for z-stream backports.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025
@everettraven
Copy link
Contributor

/assign

@liouk
Copy link
Member Author

liouk commented Oct 13, 2025

/test verify-feature-promotion

2 similar comments
@liouk
Copy link
Member Author

liouk commented Oct 15, 2025

/test verify-feature-promotion

@liouk
Copy link
Member Author

liouk commented Oct 21, 2025

/test verify-feature-promotion

@xingxingxia
Copy link

/retest-required

@xingxingxia
Copy link

Though there were still some Required jobs failing, I anyway pre-merge tested this PR + openshift/cluster-authentication-operator#802 together with

# Payload 1
build 4.20.0-0.nightly-2025-10-21-003434,openshift/api#2515,openshift/cluster-authentication-operator#802

# Payload 2
build 4.20.0-0.nightly-2025-10-21-173356,openshift/api#2515,openshift/cluster-authentication-operator#802

In a fresh env of cluster-bot payload 1, configured external oidc with Entra ID, pre-upgrade related tests passed including oc / console interactive logins, extra / uid checks, clusterversion/version and authentication.config/cluster and co/authentication's .status against their respecitve Jira bugs et al.
Upgrading of the env to cluster-bot payload 2 succeeded without the filed upgrade bug any more. Post-upgrade tests passed.
Regression tests of rollback to IDP and post-rollback interactive logins also passed.

So adding /verified label:
/verified by @xingxingxia

I didn't yet have chance to cover testing 4.19 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc, also didn't test 4.20.0 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc. Because I had tested "4.21-nightly-payload -> upgrade to 4.21-external-oidc-GA-clusterbot-payload -> configure external oidc" without issue, I believe same confidence.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 23, 2025
@openshift-ci-robot
Copy link

@xingxingxia: This PR has been marked as verified by @xingxingxia.

In response to this:

Though there were still some Required jobs failing, I anyway pre-merge tested this PR + openshift/cluster-authentication-operator#802 together with

# Payload 1
build 4.20.0-0.nightly-2025-10-21-003434,openshift/api#2515,openshift/cluster-authentication-operator#802

# Payload 2
build 4.20.0-0.nightly-2025-10-21-173356,openshift/api#2515,openshift/cluster-authentication-operator#802

In a fresh env of cluster-bot payload 1, configured external oidc with Entra ID, pre-upgrade related tests passed including oc / console interactive logins, extra / uid checks, clusterversion/version and authentication.config/cluster and co/authentication's .status against their respecitve Jira bugs et al.
Upgrading of the env to cluster-bot payload 2 succeeded without the filed upgrade bug any more. Post-upgrade tests passed.
Regression tests of rollback to IDP and post-rollback interactive logins also passed.

So adding /verified label:
/verified by @xingxingxia

I didn't yet have chance to cover testing 4.19 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc, also didn't test 4.20.0 -> upgrade to 4.20-external-oidc-GA-clusterbot-payload -> configure external oidc. Because I had tested "4.21-nightly-payload -> upgrade to 4.21-external-oidc-GA-clusterbot-payload -> configure external oidc" without issue, I believe same confidence.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liouk
Copy link
Member Author

liouk commented Oct 24, 2025

/test verify-feature-promotion

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2025

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 88a5beb link true /test e2e-aws-ovn-hypershift
ci/prow/verify-feature-promotion 88a5beb link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants