Skip to content

Conversation

ya1gaurav
Copy link
Contributor

This is to silent issues reported in #410

@ya1gaurav
Copy link
Contributor Author

Is this the required patch ?

@BillyDonahue
Copy link
Contributor

A mistake IMO. I thought the master branch was C++11 now?
I posted more of my thoughts on Issue #410.

@cdunn2001
Copy link
Contributor

Is this definitely the only problem with the master branch on VS2012? If so, then I'd favor @BillyDonahue's suggestion of a macro. But if there are other problems, then I'd say let's just not support VS2012. master is C++11 now. If you can use an old commit -- maybe an older release of 1.6.* -- fine. But the 0.10.z branch is for old systems. We try very hard not to break backward-compatibility on that branch for any system or configuration. master is moving forward.

@ya1gaurav
Copy link
Contributor Author

I absolutely agree with master branch as it is C++-11, also adding "override" was patch submitted by me. 0.10.z is already before c++-11.

@cdunn2001
Copy link
Contributor

I absolutely agree with master branch as it is C++-11... 0.10.z is already before c++-11.

But this is submitted to the master branch, which is C++11.

also adding "override" was patch submitted by me

Yes, but what difference does that make? It's there now.

@ya1gaurav
Copy link
Contributor Author

I mean i sent this patch to cross check intention for - #410
Its not needed,, so please close this pull as invalid.
Thanks.

@cdunn2001 cdunn2001 closed this Mar 6, 2016
cdunn2001 added a commit to cdunn2001/jsoncpp that referenced this pull request Mar 22, 2016
b/c MS VS2010 is supposed to be C++11 but does not fulfull
the entire standard.

Resolves open-source-parsers#410.
Re: open-source-parsers#430.
@cdunn2001 cdunn2001 mentioned this pull request Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants