Use macro for override
#449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/c MS VS2010 is supposed to be C++11 but does not fulfull the entire standard. Resolves open-source-parsers#410. Re: open-source-parsers#430.
This is wrong, It should be marked as virtual. Otherwise we are changing the behaviour of class. But, still virtual keyword is placed before function name. |
|
Are you sure it's wrong? If the base-class function is This was @BillyDonahue's suggestion, and I think it makes sense. Have you seen it actually fail somewhere? |
|
I agree with your explanation, I think I made some wrong assumption. Thanks for clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/c MS VS2010 is supposed to be C++11 but does not fulfull
the entire standard.
Resolves #410.
Re: #430.