Skip to content

Remove override keyword from dtors #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Remove override keyword from dtors #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
231e251
Remove override keyword from dtors
ya1gaurav Feb 29, 2016
f0cf3b0
Remove override keyword from dtors
ya1gaurav Feb 29, 2016
8f01b35
Remove override keyword from dtors
ya1gaurav Feb 29, 2016
5bf99d3
Remove override keyword from dtors
ya1gaurav Feb 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/json/reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ class JSON_API CharReaderBuilder : public CharReader::Factory {
Json::Value settings_;

CharReaderBuilder();
~CharReaderBuilder() override;
virtual ~CharReaderBuilder();

CharReader* newCharReader() const override;

Expand Down
2 changes: 1 addition & 1 deletion include/json/value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace Json {
class JSON_API Exception : public std::exception {
public:
Exception(std::string const& msg);
~Exception() throw() override;
virtual ~Exception() throw();
char const* what() const throw() override;
protected:
std::string msg_;
Expand Down
6 changes: 3 additions & 3 deletions include/json/writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class JSON_API StreamWriterBuilder : public StreamWriter::Factory {
Json::Value settings_;

StreamWriterBuilder();
~StreamWriterBuilder() override;
virtual ~StreamWriterBuilder();

/**
* \throw std::exception if something goes wrong (e.g. invalid settings)
Expand Down Expand Up @@ -158,7 +158,7 @@ class JSON_API FastWriter : public Writer {

public:
FastWriter();
~FastWriter() override {}
virtual ~FastWriter() {}

void enableYAMLCompatibility();

Expand Down Expand Up @@ -210,7 +210,7 @@ class JSON_API FastWriter : public Writer {
class JSON_API StyledWriter : public Writer {
public:
StyledWriter();
~StyledWriter() override {}
virtual ~StyledWriter() {}

public: // overridden from Writer
/** \brief Serialize a Value in <a HREF="http://www.json.org">JSON</a> format.
Expand Down