Fix if_linux_ipv6 verbose output of interface addresses #6797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
orivej
force-pushed
the
fix-if_linux_ipv6-addrstr
branch
from
8d20aa0 to
da10640
Compare
Member
|
ok to test |
jsquyres
requested changes
Jul 8, 2019
orivej
force-pushed
the
fix-if_linux_ipv6-addrstr
branch
from
366990a to
ecd02eb
Compare
jsquyres
force-pushed
the
fix-if_linux_ipv6-addrstr
branch
from
ecd02eb to
0d2d55b
Compare
Member
|
@orivej I just did the following:
I left these 2 additional commits so that you can easily see the changes. If you're good with them, I can re-squash all down into a single commit and we can merge when CI completes. |
orivej
commented
Jul 9, 2019
Contributor
Author
orivej
left a comment
orivej
left a comment
There was a problem hiding this comment.
Everything else looks good, thank you!
Previously the verbose output of if_linux_ipv6_open looked like this:
found interface ab c: 0ab: a b: abc: 0 0: a 0:abcd: 0 0 scope 0
This changes the output to:
found interface eth0 inet6 ab0c:ab:a0b:abc:0:a00:abcd:0 scope 0
Signed-off-by: Orivej Desh <[email protected]>
Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
fix-if_linux_ipv6-addrstr
branch
from
0d2d55b to
39b799d
Compare
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Jul 9, 2019
Unfortunately, open-mpi#6797 was merged before all feedback was received (39b799d). This PR is a minor addendum to that commit. This PR simply removes a meaningless `= {0}` operation. The use of gethostname() here -- and many other places in the code base -- is technically unsafe. See open-mpi#6801 for a further description of the issue and a suggested fix. But the risk is quite low; real-world hostnames are usually much shorter than OPAL_MAXHOSTNAMELEN. Hence, this PR just removes the meaningless operation and leaves a real fix for gethostname() usage to a potential future PR. Signed-off-by: Jeff Squyres <[email protected]>
Member
|
this should not had the v4.0.2 milestone set. That's for PRs that are going into v4.0.x. I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously verbose output of
if_linux_ipv6_openlooked like this:This changes the output to: