SQUASHME opal/if/linux_ipv6: use opal_show_help()

Convert an instance of opal_output() to opal_show_help().

Signed-off-by: Jeff Squyres <[email protected]>

Author: jsquyres

opal/mca/if/linux_ipv6/Makefile.am

@@ -1,12 +1,14 @@
 #
-# Copyright (c) 2010     Cisco Systems, Inc.  All rights reserved.
+# Copyright (c) 2019 Cisco Systems, Inc.  All rights reserved.
 # $COPYRIGHT$
 #
 # Additional copyrights may follow
 #
 # $HEADER$
 #
 
+dist_opaldata_DATA = help-opal-if-linux-ipv6.txt
+
 noinst_LTLIBRARIES = libmca_if_linux_ipv6.la
 
 libmca_if_linux_ipv6_la_SOURCES = if_linux_ipv6.c

opal/mca/if/linux_ipv6/help-opal-if-linux-ipv6.txt

@@ -0,0 +1,17 @@
+# -*- text -*-
+#
+# Copyright (c) 2019 Cisco Systems, Inc.  All rights reserved.
+# $COPYRIGHT$
+#
+# Additional copyrights may follow
+#
+# $HEADER$
+#
+[fail to parse if_inet6]
+Open MPI failed to parse at least one of the lines in
+/proc/net/if_inet6.  This is extremely unusual and should never
+happen.  Open MPI will skip this interface and attempt to continue.
+
+  Host:      %s
+  Interface: %s
+  Hex:       %s

opal/mca/if/linux_ipv6/if_linux_ipv6.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010      Cisco Systems, Inc.  All rights reserved.
+ * Copyright (c) 2010-2019 Cisco Systems, Inc.  All rights reserved.
  * Copyright (c) 2010      Oracle and/or its affiliates.  All rights reserved.
  * Copyright (c) 2018      Amazon.com, Inc. or its affiliates.  All Rights
  *                         reserved.
@@ -48,6 +48,7 @@
 #include "opal/constants.h"
 #include "opal/util/if.h"
 #include "opal/util/output.h"
+#include "opal/util/show_help.h"
 #include "opal/util/string_copy.h"
 #include "opal/mca/if/if.h"
 #include "opal/mca/if/base/base.h"
@@ -126,8 +127,11 @@ static int if_linux_ipv6_open(void)
             opal_if_t *intf;
 
             if (!hexdecode(addrhex, a6.s6_addr, sizeof a6.s6_addr)) {
-                opal_output(0, LOG_PREFIX "skipped interface %s: failed to hexdecode %s\n",
-                            ifname, addrhex);
+                char hostname[OPAL_MAXHOSTNAMELEN + 1];
+                gethostname(hostname, sizeof(hostname) - 1);
+                opal_show_help("help-opal-if-linux-ipv6.txt",
+                               "fail to parse if_inet6", true,
+                               hostname, ifname, addrhex);
                 continue;
             };
             inet_ntop(AF_INET6, a6.s6_addr, addrstr, sizeof addrstr);