opal/if/linux_ipv6: unify gethostname() call behavior #6802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, open-mpi#6797 was merged before all feedback was received (39b799d). This PR is a minor addendum to that commit. This PR simply removes a meaningless `= {0}` operation. The use of gethostname() here -- and many other places in the code base -- is technically unsafe. See open-mpi#6801 for a further description of the issue and a suggested fix. But the risk is quite low; real-world hostnames are usually much shorter than OPAL_MAXHOSTNAMELEN. Hence, this PR just removes the meaningless operation and leaves a real fix for gethostname() usage to a potential future PR. Signed-off-by: Jeff Squyres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, #6797 was merged
before all feedback was received (39b799d). This PR is a minor
addendum to that commit.
This PR simply removes a meaningless
= {0}operation.The use of gethostname() here -- and many other places in the code
base -- is technically unsafe. See
#6801 for a further description
of the issue and a suggested fix. But the risk is quite low;
real-world hostnames are usually much shorter than
OPAL_MAXHOSTNAMELEN. Hence, this PR just removes the meaningless
operation and leaves a real fix for gethostname() usage to a potential
future PR.
Signed-off-by: Jeff Squyres [email protected]
FYI @orivej