Skip to content

[IMP] sales: invoicing policy doc for RST reasons #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] sales: invoicing policy doc for RST reasons #4465

wants to merge 1 commit into from

Conversation

@ksc-odoo
Copy link
Contributor

@ksc-odoo ksc-odoo commented May 17, 2023

updated sales doc for invoicing policies for RST reasons and image reasons, suggested in this task https://www.odoo.com/web#id=3324366&cids=3&model=project.task&view_type=form
This is just for 16.0, as the images are version-specific

Project Task: https://www.odoo.com/web#id=3330511&cids=3&menu_id=4720&action=333&active_id=3835&model=project.task&view_type=form

@ksc-odoo ksc-odoo self-assigned this May 17, 2023
@robodoo
Copy link
Collaborator

robodoo commented May 17, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team May 17, 2023 19:28
@ksc-odoo ksc-odoo requested a review from a team May 17, 2023 19:29
@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from 4ce4501 to 381154e Compare May 18, 2023 18:49
hojo-odoo
hojo-odoo reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@hojo-odoo hojo-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo,

Let me know if you have any questions about my comments.

Thanks,
hojo

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from 381154e to 873e6a6 Compare June 8, 2023 21:54
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 8, 2023

Thanks for the super-helpful feedback/suggestions, @hojo-odoo - I made all the necessary adjustments, and I think it's ready for a Tech Review from @samueljlieber - Thanks again 👍

@ksc-odoo ksc-odoo requested a review from samueljlieber June 8, 2023 21:56
samueljlieber
samueljlieber requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! This PR is looking pretty good :) I have just a couple technical corrections, please see below and then tag me again for another look!

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch 2 times, most recently from 0c6893b to 8a95e17 Compare June 20, 2023 21:40
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 20, 2023

Hi @ksc-odoo! This PR is looking pretty good :) I have just a couple technical corrections, please see below and then tag me again for another look!

@samueljlieber just made all your suggested edits - ready for another review from you, whenever you get a chance 👍 Thanks!

@ksc-odoo ksc-odoo requested a review from samueljlieber June 20, 2023 21:50
samueljlieber
samueljlieber approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo 👋 great job with the improvements to this doc! This PR is looking great to me, I found just a few more small improvements. Please see below and correct them before sending to final review. I am approving now 🙂

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from 8a95e17 to 9c947f7 Compare June 26, 2023 18:29
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jun 26, 2023

@StraubCreative this one's ready for Final Review 👍

@ksc-odoo ksc-odoo requested a review from StraubCreative June 26, 2023 18:33
@StraubCreative StraubCreative requested a review from a team July 18, 2023 17:55
meng-odoo
meng-odoo suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@meng-odoo meng-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo! Great job on this doc. I just had tiny formatting changes and one clarifying question. Once you've made those changes, we'll tag Sam for one more quick technical review before merging. Please let me know if you have any questions :)

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from 9c947f7 to 7e29e0a Compare July 31, 2023 21:58
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Jul 31, 2023

Hi @ksc-odoo! Great job on this doc. I just had tiny formatting changes and one clarifying question. Once you've made those changes, we'll tag Sam for one more quick technical review before merging. Please let me know if you have any questions :)

Hey there, @meng-odoo -- just finished making all your suggested edits. Thanks for the thorough review. I believe this is now ready for another quick technical review from @samueljlieber 👍

@ksc-odoo ksc-odoo requested a review from samueljlieber July 31, 2023 22:02
samueljlieber
samueljlieber approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ksc-odoo 👋 great job with the improvements in this PR, I found a single very small technical change. I am approving now, but please make this correction before tagging for merge. Nice work!

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from 7e29e0a to c10af42 Compare August 2, 2023 14:18
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Aug 2, 2023

Hey @ksc-odoo 👋 great job with the improvements in this PR, I found a single very small technical change. I am approving now, but please make this correction before tagging for merge. Nice work!

Hey @samueljlieber - thanks for the quick review. Made that suggested edit, so I believe this is ready to merge... ready for your final review @StraubCreative

StraubCreative
StraubCreative approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksc-odoo
Approving with comments for you to consider now or on a future PR.
At some point, we'll want to update the screenshots to feature the UI, as well.

Up to you, however we can merge right away if you like 🙏

@robodoo delegate=ksc-odoo

@ksc-odoo ksc-odoo force-pushed the 16.0-sales-update-invoicing-policy-doc-ksc branch from c10af42 to 5076e19 Compare August 7, 2023 18:09
@ksc-odoo
Copy link
Contributor Author

ksc-odoo commented Aug 7, 2023

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 7, 2023
@ksc-odoo
[IMP] sales: invoicing policy doc for RST reasons
acc2c79 
closes #4465

Signed-off-by: Kevin Scannell (ksc) <[email protected]>
@robodoo robodoo temporarily deployed to merge August 7, 2023 19:51 Inactive
@robodoo robodoo closed this Aug 7, 2023
This was referenced Aug 7, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+2 more reviewers

@hojo-odoo hojo-odoo hojo-odoo left review comments

@meng-odoo meng-odoo meng-odoo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ksc-odoo ksc-odoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ksc-odoo @robodoo @StraubCreative @samueljlieber @meng-odoo @hojo-odoo