[ADD] Payroll: Mexico localization #14767
Conversation
|
|
|
Hi @mial-odoo - would you please take a look at this PR, and let me know if there are any changes needed? I followed your document, but I moved some things and rephrased a few things to keep it in line with the template. Any questions, let me know! I am mostly concerned that everything is accurate and correct. Thank you! |
mial-odoo
left a comment
mial-odoo
left a comment
There was a problem hiding this comment.
It is looking amazing! Just a few unexpected references, but other than that is pretty good! Thanks
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
|
Hello @mial-odoo - I have left some comments, since I am unsure how to fix or rephrase some of the sections you commented on. Mostly because I still am unsure of how the entire Mexico payroll functions. Can you help with those 3 incorrectly worded parts mentioned above? Once I know those are correct and accurate, i think this is in good shape for a final tech review! =) |
larm-odoo
force-pushed
the
19.0-payroll-mexico-localization-larm
branch
from
d08dbee to
7e6b7c8
Compare
|
@Felicious - this is ready for a final tech review |
|
@larm-odoo It's perfect, thanks for everything! :) |
|
Hi @mial-odoo - I see you added items to this PR for the Mexico Fiscal Localization, but this PR is only for the Payroll localization. Could you please remove those additional changes to the fiscal document only, and place those edits on a separate PR, since I created this only for the new doc? Thank you! |
Sorry, I asked Felicia if I could do it here, I don't use the console so I can't remove it :( |
Felicious
force-pushed
the
19.0-payroll-mexico-localization-larm
branch
2 times, most recently
from
6b41952 to
c035178
Compare
|
I took a look at @mial-odoo's changes, and since he's just adding some links in the fiscal localization doc to this payroll one, I don't think the @odoo/accounting-doc-review would find issue in our changes to their doc. I've tagged them in this thread in case, though, so feel free to comment if you'd like us to remove our edits! So @larm-odoo, I think we can leave Miguel's links as-is! |
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Lovely new doc, @larm-odoo!!
Everything looks wonderful and is written clearly and concisely. I just had some very small optional suggestions that you can look over. After that, this is definitely ready for merge!
@robodoo delegate+
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
content/applications/hr/payroll/payroll_localizations/mexico.rst
Outdated
Show resolved
Hide resolved
larm-odoo
force-pushed
the
19.0-payroll-mexico-localization-larm
branch
from
c035178 to
ee6e029
Compare
|
@robodoo r+ |
Previous commits ended up with a little less info than intended so this PR adds two things: Fixes the missing picture in #14582 And adds references to #14767 Co-authored-by: StraubCreative <[email protected]> Co-authored-by: dade-odoo <[email protected]>
Previous commits ended up with a little less info than intended so this PR adds two things: Fixes the missing picture in #14582 And adds references to #14767 closes #14805 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: StraubCreative <[email protected]> Co-authored-by: dade-odoo <[email protected]>
Previous commits ended up with a little less info than intended so this PR adds two things: Fixes the missing picture in #14582 And adds references to #14767 X-original-commit: 61aab62 Co-authored-by: StraubCreative <[email protected]> Co-authored-by: dade-odoo <[email protected]>
Previous commits ended up with a little less info than intended so this PR adds two things: Fixes the missing picture in #14582 And adds references to #14767 closes #14868 X-original-commit: 61aab62 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: StraubCreative <[email protected]> Co-authored-by: dade-odoo <[email protected]>
Adding new localization info. This document was provided by Miguel Angel Lopez (MIAL).
Original task card for this PR.