[IMP] l10n_mx: update refactored functions in Odoo 19

[mial-odoo]

19.0 saw a lot of changes to core loc functions, this adds information about them, some will have to be added later on a different payroll section.

Added:
-New customs numbers
-New stock landing with fleet
-New re-invoicing account and default credit notes account.

Removed
-References to how valuation used to work in v18.4 and older.

[robodoo]

[StraubCreative]

96e46f2: squashed commits, renamed commit description

Notes:

• branch naming convention: version-app-brief-description-gram
  • The live doc's instructions on this are out of date. We do it this way so Runbot works, the correct teams are tagged, and the branch name can clearly (but briefly) state what it's about, which improves our version control.
• commit naming convention: [TAG] app/module: brief description under 50 chars. Also helps version control and correct teams are addressing quickly.
• Squash multiple commits into one, if possible (terminal users only, if using GitHub interface we can gladly do that for you ;) )

[StraubCreative]

Results from make review check (mostly formatting)

content/applications/finance/fiscal_localizations/mexico.rst:518: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:519: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:523: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1366: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1367: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1572: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1587: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1588: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1625: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1634: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1645: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1724: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:1725: trailing whitespace (trailing-whitespace)
content/applications/finance/fiscal_localizations/mexico.rst:517: Line too long (101/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1024: Line too long (101/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1726: Line too long (103/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1645: missing underscore after closing backtick in hyperlink (missing-underscore-after-hyperlink)
content/applications/finance/fiscal_localizations/mexico.rst:89: consider moving "and" to line 89 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1365: consider moving "<../../sales/point_of_sale/configuration>`," to line 1365 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1366: consider moving "payment" to line 1366 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1372: consider moving "and" to line 1372 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1569: consider moving "products" to line 1569 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1588: consider moving ":guilabel:`Periodic" to line 1588 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1645: consider moving "of" to line 1645 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1712: consider moving "the" to line 1712 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1713: consider moving "after" to line 1713 (early-line-breaks)

Will fix these first and push up the changes, stand by...

[StraubCreative]

Results from make review check (mostly formatting)
...
Will fix these first and push up the changes, stand by...

Deployment errors (fixing now)

content/applications/finance/fiscal_localizations/mexico.rst:1574: WARNING: Inline interpreted text or phrase reference start-string without end-string.
content/applications/finance/fiscal_localizations/mexico.rst:1775: WARNING: Unexpected indentation.
content/applications/finance/fiscal_localizations/mexico.rst:1365: WARNING: undefined label: mx/pos/portal
content/applications/finance/fiscal_localizations/mexico.rst:1574: WARNING: unknown document: ../../inventory_valuation/valuation_by_lots
content/applications/finance/fiscal_localizations/mexico.rst:1586: WARNING: unknown document: inventory valuation <../../inventory/product_management/inventory_valuation> is set to either :guilabel:`Periodic (at closing)
content/applications/finance/fiscal_localizations/mexico.rst:1610: WARNING: unknown document: Landed Costs here

[StraubCreative]

e6052f3: make checks and errors resolved (except 2 lines that are >100 char due to long hyperlinks), compressed new images added on this PR, fixed typos as I came across them.

[StraubCreative]

CI checks pass ✅
Thank you for your contribution @mial-odoo!

This is ready for content review now @odoo/localizations-doc-review
We will implement your changes as you identify them, thanks!

[dade-odoo]

Thanks for your patience on this one @mial-odoo ! Let me know if any of my comments/questions are unclear.
I realize that several of my comments are about content that wasn't updated in this PR. For those, you can update them here and leave them as they are in 18.0, or a better solution would be to make those changes in a separate PR that targets 18.0. We need to create a separate PR targeting 18.0 anyway because it looks like 3 images from that version use 32-bit color and weren't pngquanted. I suggest this second option :)
Thanks again for your hard work and great job getting updated for 19.0 so quickly! ⚡

[dade-odoo]

Thanks for your patience on this one @mial-odoo ! Let me know if any of my comments/questions are unclear.
I realize that several of my comments are about content that wasn't updated in this PR. For those, you can update them here and leave them as they are in 18.0, or a better solution would be to make those changes in a separate PR that targets 18.0. We need to create a separate PR targeting 18.0 anyway because it looks like 3 images from that version use 32-bit color and weren't pngquanted. I suggest this second option :)
Thanks again for your hard work and great job getting updated for 19.0 so quickly! ⚡

[mial-odoo]

I updated everything but a few comments that I'm not sure how to handle and left comments on those :)

[StraubCreative]

Errors read out...fixing now.

content/applications/finance/fiscal_localizations/mexico.rst:917: Line too long (103/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1012: Line too long (101/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1577: Line too long (104/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1607: Line too long (115/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1614: Line too long (116/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1615: Line too long (120/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1708: Line too long (152/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1716: Line too long (101/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:1757: Line too long (102/100) (line-too-long)
content/applications/finance/fiscal_localizations/mexico.rst:820: consider moving "differences" to line 820 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1745: consider moving "-->" to line 1745 (early-line-breaks)
content/applications/finance/fiscal_localizations/mexico.rst:1828: consider moving "example," to line 1828 (early-line-breaks)

[StraubCreative]

633dee2:

• CI and make checks pass ✅
• known line length issues on 1012 and 1577 due to long hyperlinks

This should be good for another look @dade-odoo

[dade-odoo]

@StraubCreative thanks for your help on this. It's ready for an r+ :)
cc: @mial-odoo

[StraubCreative]

@robodoo r+

[mial-odoo]

@StraubCreative @dade-odoo I see that one of the pics I uploaded was removed in a commit, the problem with that is that it was replacing a picture that has configurations for the v18 valuation where my picture was for the v19 valuation so what should we do? hehe

https://www.odoo.com/documentation/19.0/applications/finance/fiscal_localizations/mexico.html#id7

[StraubCreative]

... so what should we do?

No problem @mial-odoo. If it's an important screenshot or replaces an older version, then I can drop it in a new PR.
Is this the image you want to use, in the comment you posted today?
If so, where should it go in the documentation?

Cc: @dade-odoo

[mial-odoo]

... so what should we do?

No problem @mial-odoo. If it's an important screenshot or replaces an older version, then I can drop it in a new PR. Is this the image you want to use, in the comment you posted today? If so, where should it go in the documentation?

Cc: @dade-odoo

Yes, that is the screenshot, replaces "mx-landing-configuration-category"