Test #2
Merged
Test #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Hipwell <[email protected]>
* Add AWS Health event support for QP mode * Update QP Scheduled Change event drain time, README, taint type * Add AWS Health event support for QP mode * Update QP Scheduled Change event drain time, README, taint type * Update AWS Health event handler names, update e2e run command with ASG system tag * Add AWS Health event support for QP mode * Update QP Scheduled Change event drain time, README, taint type * Update AWS Health event handler names, update e2e run command with ASG system tag * Improve comments related to Health events and scheduled changes * Reduce scope of several variables Co-authored-by: Austin Siu <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
* community meeting announcement * Update README.md * Update README.md
Fixing typo error in helm chart values
Co-authored-by: ec2-bot 🤖 <[email protected]>
* removed Arch affinity Signed-off-by: Nitin Goyal <[email protected]> * removed OS node selector from nodeAffinity Signed-off-by: Nitin Goyal <[email protected]> * fargate nodeAffinity moved to values.yaml Signed-off-by: Nitin Goyal <[email protected]> * fargate nodeAffinity moved to values.yaml Signed-off-by: Nitin Goyal <[email protected]>
* Add: support custom labels Signed-off-by: Nicolas Lamirault <[email protected]> * Fix: do not add custom labels Signed-off-by: Nicolas Lamirault <[email protected]>
Add TAINT_EFFECT env var and --taint-effect flag to configure the node taint effect Defaults to NoSchedule, garbage values will log a warning and default to NoSchedule. closes #273
Co-authored-by: liorf <[email protected]>
Signed-off-by: Steve Hipwell <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
* Support ASG->SQS lifecycle termination events * Update README with instructions for ASG->SQS direct lifecycle term events * Improve readability and naming * Rearrange QP setup instructions for clarity * Update logging to clarify unsupported cases
* allow for dnsConfig directive * 📝 readme
Signed-off-by: Steve Hipwell <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
* add and remove exclude-from-external-load-balancers label * move dry run after checking the label's value * update helm and helm README * wording nit
* refactor gha workflows into separate files and run build and test jobs on a periodic * remove monolith gha file
* Add support for docker buildx on linux builds This ensures that the platform in the image manifest matches the platform of the binaries. * Use docker buildx in the integration test suite too * Delete the local manifest list before adding the new image to it. This ensures that we will keep any existing images in the remote manifest when we add the new image to that manifest list. * Improve local build instructions and remove passive voice
* Fix release script prompt when calling from a golang program For some reason, `read -p` doesn't properly print to stdout when invoked through golang's `exec.Command().Run()`, but `echo` does. Reading from stdin still works correctly. * 🥑🤖 v1.16.0 release prep 🤖🥑 Co-authored-by: ec2-bot 🤖 <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
In all other creations of `InterruptionEvent`, the `IsManaged` field is populated via `getNodeInfo`. This seems to have been missed in the work to support Scheduled Events. Without this, managed node checking doesn't work correctly for scheduled events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.