Test

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,5 +1,6 @@
-Issue #, if available:
+**Issue #, if available:**
+
+**Description of changes:**
 
-Description of changes:
 
 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

.github/workflows/ci.yml → .github/workflows/build-and-test.yaml

@@ -1,6 +1,16 @@
-name: NTH Continuous Integration and Release
-
-on: [push, pull_request, workflow_dispatch]
+name: Build and Test
+
+on:
+  push:
+    branches:
+      - main
+    tags-ignore:
+      - "v*.*.*"
+  pull_request:
+  workflow_dispatch:
+  # Run M-F at 5AM CDT
+  schedule:
+    - cron: '0 10 * * 1-5'
 
 env:
   DEFAULT_GO_VERSION: ^1.16
@@ -9,11 +19,9 @@ env:
   WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
 
 jobs:
-
   fastTests:
-    name: Fast Tests and Lints
+    name: Fast Test
     runs-on: ubuntu-20.04
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     steps:
     - name: Set up Go 1.x
       uses: actions/setup-go@v2
@@ -23,6 +31,15 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
+    - name: Restore go mod cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
+
     - name: Unit Tests
       run: make unit-test
 
@@ -34,16 +51,21 @@ jobs:
       env: 
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-    - name: Run golangci-lint
-      uses: golangci/[email protected]
-
     - name: Generate K8s YAML
       run: make generate-k8s-yaml
 
+  golangci:
+    # this action needs to run in its own job per setup
+    name: Lint Eastwood
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up golangci-lint
+        uses: golangci/[email protected]
+
   buildLinux:
     name: Build Linux Binaries
     runs-on: ubuntu-20.04
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     steps:
     - name: Set up Go 1.x
       uses: actions/setup-go@v2
@@ -52,19 +74,37 @@ jobs:
 
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
+
+    - name: Restore go mod cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
+
     - name: Build Linux Binaries
       run: make build-binaries
 
   buildLinuxDocker:
     name: Build Linux Docker Images
     runs-on: ubuntu-20.04
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     steps:
     - name: Set up Go 1.x
       uses: actions/setup-go@v2
       with:
         go-version: ${{ env.DEFAULT_GO_VERSION }}
 
+    - name: Restore go mod cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
+
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
@@ -74,7 +114,6 @@ jobs:
   buildWindows:
     name: Build Windows Binaries
     runs-on: windows-2019
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     steps:
     - name: Set up Go 1.x
       uses: actions/setup-go@v2
@@ -84,13 +123,21 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
+    - name: Restore go mod cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
+
     - name: Build Windows Binaries
       run: choco install make && choco install zip && RefreshEnv.cmd && make build-binaries-windows
 
   buildWindowsDocker:
     name: Build Windows Docker Images
     runs-on: windows-2019
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     steps:
     - name: Set up Go 1.x
       uses: actions/setup-go@v2
@@ -100,13 +147,21 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
+    - name: Restore go mod cache
+      uses: actions/cache@v2
+      with:
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
+
     - name: Build Windows Docker Images
       run: choco install make && RefreshEnv.cmd && make build-docker-images-windows
 
   e2e:
     name: E2E Tests
     runs-on: ubuntu-20.04
-    if: ${{ !contains(github.ref, 'refs/tags/') }}
     strategy:
       matrix:
         k8sVersion: ["1.17", "1.18", "1.19", "1.20", "1.21", "1.22"]
@@ -119,72 +174,14 @@ jobs:
     - name: Check out code into the Go module directory
       uses: actions/checkout@v2
 
-    - name: E2E Tests
-      run: test/k8s-local-cluster-test/run-test -v ${{ matrix.k8sVersion }}
-
-  releaseLinux:
-    name: Release Linux
-    runs-on: ubuntu-20.04
-    if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
-    steps:
-    - name: Set up Go 1.x
-      uses: actions/setup-go@v2
-      with:
-        go-version: ${{ env.DEFAULT_GO_VERSION }}
-
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
-
-    - name: Release Linux Assets
-      run: make release
-      env:
-        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
-
-  releaseWindows:
-    name: Release Windows
-    runs-on: windows-2019
-    if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
-    steps:
-    - name: Set up Go 1.x
-      uses: actions/setup-go@v2
+    - name: Restore go mod cache
+      uses: actions/cache@v2
       with:
-        go-version: ${{ env.DEFAULT_GO_VERSION }}
+        path: |
+          ~/.cache/go-build
+          ~/go/pkg/mod
+          ~/go/bin/
+        key: gocache
 
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
-
-    - name: Release Windows Assets
-      run: choco install make && choco install zip && RefreshEnv.cmd && make release-windows
-      env:
-        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
-
-  release:
-    name: Release
-    runs-on: ubuntu-20.04
-    needs: [releaseLinux, releaseWindows]
-    if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
-    steps:
-    - name: Set up Go 1.x
-      uses: actions/setup-go@v2
-      with:
-        go-version: ${{ env.DEFAULT_GO_VERSION }}
-
-    - name: Check out code into the Go module directory
-      uses: actions/checkout@v2
-
-    - name: Create eks-charts PR
-      run: make ekscharts-sync-release
-
-    - name: Sync Readme to ECR Public
-      run: make sync-readme-to-ecr-public
-      env:
-        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
-
-    - name: Create NTH README Update PR
-      run: make create-release-prep-pr-readme
+    - name: E2E Tests
+      run: test/k8s-local-cluster-test/run-test -v ${{ matrix.k8sVersion }}

.github/workflows/release.yaml

@@ -0,0 +1,80 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - "v*.*.*"
+
+permissions:
+  contents: write # required for uploading releases
+
+env:
+  DEFAULT_GO_VERSION: ^1.16
+  GITHUB_USERNAME: ${{ secrets.EC2_BOT_GITHUB_USERNAME }}
+  GITHUB_TOKEN: ${{ secrets.EC2_BOT_GITHUB_TOKEN }}
+  WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
+
+jobs:
+  releaseLinux:
+    name: Release Linux
+    runs-on: ubuntu-20.04
+    steps:
+    - name: Set up Go 1.x
+      uses: actions/setup-go@v2
+      with:
+        go-version: ${{ env.DEFAULT_GO_VERSION }}
+
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v2
+
+    - name: Release Linux Assets
+      run: make release
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
+
+  releaseWindows:
+    name: Release Windows
+    runs-on: windows-2019
+    steps:
+    - name: Set up Go 1.x
+      uses: actions/setup-go@v2
+      with:
+        go-version: ${{ env.DEFAULT_GO_VERSION }}
+
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v2
+
+    - name: Release Windows Assets
+      run: choco install make && choco install zip && RefreshEnv.cmd && make release-windows
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
+
+  release:
+    name: Release
+    runs-on: ubuntu-20.04
+    needs: [releaseLinux, releaseWindows]
+    steps:
+    - name: Set up Go 1.x
+      uses: actions/setup-go@v2
+      with:
+        go-version: ${{ env.DEFAULT_GO_VERSION }}
+
+    - name: Check out code into the Go module directory
+      uses: actions/checkout@v2
+
+    - name: Create eks-charts PR
+      run: make ekscharts-sync-release
+
+    - name: Sync Readme to ECR Public
+      run: make sync-readme-to-ecr-public
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
+
+    - name: Create NTH README Update PR
+      run: make create-release-prep-pr-readme

.github/workflows/stale.yml

@@ -21,6 +21,7 @@ jobs:
           days-before-issue-close: -1
           remove-stale-when-updated: true
           stale-pr-label: "stale"
+          operations-per-run: 100
           stale-pr-message: >
             This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
             If you want this PR to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.
@@ -40,6 +41,7 @@ jobs:
           days-before-pr-close: -1
           remove-stale-when-updated: true
           stale-issue-label: "stale"
+          operations-per-run: 100
           stale-issue-message: >
             This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
             If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.