Move golangci-lint action to its own job

[brycahta]

Issue #, if available:

• GHA displaying error annotations on successful cicd runs #589
• golangci-lint failed:[error]/bin/tar:xxxx Cannot open: File exists golangci/golangci-lint-action#23

Description of changes

Moving golangci-lint into its own job per the updated onboarding instructions

Contribution disclaimer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[snay2]

Do these jobs run in order, and only after the previous jobs complete successfully? If so, it might make sense to put the linter first since it runs faster than the test suite. That would make the feedback loop quicker in the event of a failure.

[brycahta]

Do these jobs run in order, and only after the previous jobs complete successfully?

No, these are concurrent (or at least requests to run are concurrent). The functionality you're describing is achieved using needs like in our release workflow:

  release:
    name: Release
    runs-on: ubuntu-20.04
    needs: [releaseLinux, releaseWindows]
    steps:
    - name: Set up Go 1.x
      uses: actions/setup-go@v2
      with:
        go-version: ${{ env.DEFAULT_GO_VERSION }}