Skip to content

Move golangci-lint action to its own job #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Move golangci-lint action to its own job #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/build-and-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:

jobs:
fastTests:
name: Fast Tests and Lints
name: Fast Test
runs-on: ubuntu-20.04
steps:
- name: Set up Go 1.x
Expand Down Expand Up @@ -51,12 +51,18 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run golangci-lint
uses: golangci/[email protected]

- name: Generate K8s YAML
run: make generate-k8s-yaml

golangci:
# this action needs to run in its own job per setup
name: Lint Eastwood
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Set up golangci-lint
uses: golangci/[email protected]

buildLinux:
name: Build Linux Binaries
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -178,4 +184,4 @@ jobs:
key: gocache

- name: E2E Tests
run: test/k8s-local-cluster-test/run-test -v ${{ matrix.k8sVersion }}
run: test/k8s-local-cluster-test/run-test -v ${{ matrix.k8sVersion }}