Fixes #19610: FieldError when sorting Tunnel Termination on tenant #19612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
Member
Author
|
@arthanson , I marked this as a draft until #19600 is merged, so that I can take an exception out of the test I added in this PR. |
arthanson
previously approved these changes
Jun 3, 2025
Collaborator
|
@jnovinger approved but not merging right now as waiting for changes from #19600 |
jnovinger
force-pushed
the
19610-tenant-field-error-tunnel-terminations-table
branch
from
986709d to
269024d
Compare
Member
Author
|
@arthanson , this is rebased and ready to go. |
arthanson
approved these changes
Jun 4, 2025
jnovinger
deleted the
19610-tenant-field-error-tunnel-terminations-table
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19610
It turns out that the
TunnelTerminationmodel doesn't implement the tenancy "protocol", in that there are no foreign keys to a tenant or tenant group. It looks likeTenancyColumnsMixinwas added toTunnelTerminationTableby mistake in completing #9816.