Skip to content

Conversation

@jnovinger
Copy link
Member

@jnovinger jnovinger commented May 29, 2025

Fixes: #19487

Fixes both issues mentioned in #19487:

  • Sorting on CircuitTerminationTable.termination ('Termination Point' column) throws FieldError
  • Sorting on TunnelTerminationTable.termination ('Tunnel Interface' column) throws FieldError
  • Adds a regression test

@jnovinger jnovinger marked this pull request as draft May 29, 2025 16:27
@jnovinger jnovinger changed the title Fixes #19487: make CircuitTermination.termination GFK not orderable Fixes #19487: make CircuitTermination.termination GFK non-orderable May 29, 2025
@jnovinger jnovinger changed the title Fixes #19487: make CircuitTermination.termination GFK non-orderable Fixes #19487: fix ordering issues with CircuitTerminationTable/TunnelTerminationTable configuration May 29, 2025
@jnovinger jnovinger marked this pull request as ready for review May 29, 2025 16:58
@jnovinger jnovinger requested review from a team and bctiemann and removed request for a team May 29, 2025 16:58
@jnovinger jnovinger marked this pull request as draft May 30, 2025 18:07
@jnovinger jnovinger marked this pull request as ready for review May 30, 2025 18:17
@jnovinger jnovinger merged commit 95d0ca5 into main Jun 4, 2025
10 checks passed
@jnovinger jnovinger deleted the 19487-handle-sorting-termination-throws-field-error branch June 4, 2025 16:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field 'termination' does not generate an automatic reverse relation and therefore cannot be used for reverse querying.

3 participants