16756 fix script result pagination issue #17129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Aug 12, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
We can't just copy code out of the included template and tweak it, as that results in duplicated code that assuredly will not be maintained over time. You'll need to dig deeper and find a solution that allows efficient reuse of the template.
| <div class="table-responsive" id="object_list"> | ||
| <h5 class="card-header">{% trans "Log" %}</h5> | ||
| {% include 'htmx/table.html' %} | ||
| {% include 'htmx/table.html' with no_htmx_container=True%} |
Member
There was a problem hiding this comment.
I don't think this is a pattern we want to encourage. I'm going to see if I can come up with a cleaner fix for this.
Member
|
Closing this in favor of #17290 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16756