Skip to content

16756 fix script result pagination issue #17129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

16756 fix script result pagination issue #17129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b21ee4
16756 fix script result pagination issue
arthanson Aug 12, 2024
f64050a
16756 don't duplicate code
arthanson Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netbox/templates/extras/htmx/script_result.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ <h5 class="card-header">{% trans "Test Summary" %}</h5>
<div class="card">
<div class="table-responsive" id="object_list">
<h5 class="card-header">{% trans "Log" %}</h5>
{% include 'htmx/table.html' %}
{% include 'htmx/table.html' with no_htmx_container=True%}
Copy link
Member

@jeremystretch jeremystretch Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a pattern we want to encourage. I'm going to see if I can come up with a cleaner fix for this.

</div>
</div>
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion netbox/templates/htmx/table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{% load helpers %}
{% load render_table from django_tables2 %}

<div class="htmx-container table-responsive">
<div class="{% if not no_htmx_container %}htmx-container{% endif %} table-responsive">
{% with preferences|get_key:"pagination.placement" as paginator_placement %}
{% if paginator_placement == 'top' or paginator_placement == 'both' %}
{% include 'inc/paginator.html' with htmx=True table=table paginator=table.paginator page=table.page placement='top' %}
Expand Down