Skip to content

Fixes #16756: Fix table pagination for custom script results #17290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fixes #16756: Fix table pagination for custom script results #17290

merged 1 commit into from
Aug 28, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Aug 28, 2024

Fixes: #16756

Submitting this as an alternate to PR #17129.

  • Provide a hook in ScriptResultView to return only the rendered table
  • Load the log as an HTMX table (though not using the {% htmx_table %} tag due to a limitation concerning view name resolution)
  • Cleanup: Remove obsolete code from script_result.html

@jeremystretch jeremystretch merged commit 50839fc into develop Aug 28, 2024
@jeremystretch jeremystretch deleted the 16756-fix-script-results-display branch August 28, 2024 20:24
@jeremystretch jeremystretch mentioned this pull request Aug 28, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

script page elements are duplicated when log output is paginated and browsed

3 participants

@jeremystretch @arthanson