16232 only remove checkbox on embedded tables #16233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return redirect(f'{request.path}?{query_params.urlencode()}') | ||
|
|
||
| def _is_embedded_path(self, request): | ||
| if 'return_url' in request.GET: |
Member
There was a problem hiding this comment.
We can't rely on return_url as an indicator for the nature of the request.
Member
|
I ended up taking a different, more concrete approach in #16239. We should still dedicate some time at some point to doing some general cleanup around embedded tables, but I think this suffices for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16232
Not 100% sure of this solution, relies on the 'return_url' which will be for bulk operations not being the same as the request path. As this routine tries to set if the table is embedded, I'm not sure if there is another flag to look at that would be different if it is a main table or embedded.