Skip to content

16232 only remove checkbox on embedded tables #16233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

16232 only remove checkbox on embedded tables #16233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion netbox/netbox/views/generic/bulk_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ def export_template(self, template, request):
query_params.pop('export')
return redirect(f'{request.path}?{query_params.urlencode()}')

def _is_embedded_path(self, request):
if 'return_url' in request.GET:
Copy link
Member

@jeremystretch jeremystretch May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't rely on return_url as an indicator for the nature of the request.

if request.GET['return_url'] != request.path:
return True

return False

#
# Request handlers
#
Expand Down Expand Up @@ -163,7 +170,7 @@ def get(self, request):

# If this is an HTMX request, return only the rendered table HTML
if htmx_partial(request):
if not request.htmx.target:
if not request.htmx.target and self._is_embedded_path(request):
table.embedded = True
# Hide selection checkboxes
if 'pk' in table.base_columns:
Expand Down