Skip to content

Fixes #16232: Fix inclusion of bulk action checkboxes on dynamic tables #16239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

Fixes #16232: Fix inclusion of bulk action checkboxes on dynamic tables #16239

merged 1 commit into from
May 22, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented May 22, 2024

Fixes: #16232

  • Update the htmx_table template tag used to embed object tables so that it passes embedded=True as a URL parameter.
  • Update the logic in ObjectListView to check for the presence of embedded=True rather than an HTMX target
  • Misc cleanup of NetBoxTable

@jeremystretch jeremystretch requested a review from arthanson May 22, 2024 12:32
@jeremystretch jeremystretch mentioned this pull request May 22, 2024
Closed
@jeremystretch jeremystretch merged commit 83d3de2 into develop May 22, 2024
@jeremystretch jeremystretch deleted the 16232-fix-htmx-table-checkboxes branch May 22, 2024 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Netbox UI. Checkbox disappearing in any Table (Site, Rack, etc) after clicking to next page

3 participants

@jeremystretch @arthanson