CXX-3321 Enable CSFLE for sanitizer tasks #1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
changed the title
Contributor
Author
|
It looks like these changes also exposed CDRIVER-5998 on Windows distros. Created CXX-3321 to track this issue (for pending "bump to mongoc 2.1.0" ticket). |
Contributor
Author
|
Pinning mongoc to pre-2.1.0 release also brings in CDRIVER-5956. Bumped minimum server versions for tasks from 4.0 to 4.2 accordingly (CXX-3259). |
kevinAlbs
approved these changes
Jul 30, 2025
| # - BSON_REQUIRED_VERSION and MONGOC_REQUIRED_VERSION in CMakeLists.txt | ||
| # - the version of pkg:github/mongodb/mongo-c-driver in etc/purls.txt | ||
| # - the default value of --c-driver-build-ref in etc/make_release.py | ||
| # Only MONGOC_DOWNLOAD_VERSION needs to be updated when pinning to an unreleased commit. |
Collaborator
There was a problem hiding this comment.
Noting: I expect setting MONGOC_DOWNLOAD_VERSION is not needed since most Evergreen tasks use InstallCDriver to install the C driver dependency, rather than rely on the C driver downloaded from CMake (which does not build with libmongocrypt).
| ('rhel80', None, ['Debug'], ['shared', 'static'], [11, 17], [None], ['plain', 'csfle'], [ '4.2', '4.4', '5.0', '6.0', '7.0', '8.0', 'latest'], ['single', 'replica', 'sharded']), | ||
| ('rhel80', None, ['Debug'], ['shared', 'static'], [11, 17], [None], ['plain', ], ['4.0', ], ['single', 'replica', 'sharded']), # CSFLE: 4.2+. | ||
| ('rhel80', None, ['Debug'], ['shared', 'static'], [11, 17], [None], ['plain', 'csfle'], ['4.2', '4.4', '5.0', '6.0', '7.0', '8.0', 'latest'], ['single', 'replica', 'sharded']), | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggest also adding to CHANGELOG.md (though could also be done during next release):
### Removed
- Support for MongoDB Server 4.0 (due to the minimum required C Driver version).
eramongodb
added a commit
to eramongodb/mongo-cxx-driver
that referenced
this pull request
Oct 24, 2025
* Reduce sanitizers matrix to static library linkage * Print name of test executable being executed * Pin mongoc_version_minimum to 912209d (CDRIVER-5960) * CXX-3259 bump minimum server version from 4.0 to 4.2 (CDRIVER-5956) * Update MONGOC_VERSION_MINIMUM to better document current practices
eramongodb
added a commit
that referenced
this pull request
Oct 24, 2025
…ixes (#1490) * CXX-3278 update invalid URIs in CSE endpoint tests (#1395) * update test case 4 * replace `.local` with `.invalid` * Migrate EVG tasks from RHEL 7.6 to RHEL 7.9 (#1414) * CXX-3273 revert to using system-installed valgrind (#1400) * CXX-3311 Remove Debian 10 EVG task coverage (#1423) * CXX-3321 Enable CSFLE for sanitizer tasks (#1434) * Reduce sanitizers matrix to static library linkage * Print name of test executable being executed * Pin mongoc_version_minimum to 912209d (CDRIVER-5960) * CXX-3259 bump minimum server version from 4.0 to 4.2 (CDRIVER-5956) * Update MONGOC_VERSION_MINIMUM to better document current practices * Use uvx for CMake and Server Toolchain for Ninja (#1428) * Upgrade uv to 0.8.6 with checksum validation * Consistently use CMAKE_BUILD_PARALLEL_LEVEL (/maxcpucount) for MSBuild * Set ASAN_SYMBOLIZER_PATH to mongodbtoolchain v4 (#1446) * Generate EVG configuration with ASAN_SYMBOLIZER_PATH (#1450) * CXX-3270 remove serverless testing (#1459) * Remove serverless testing EVG configs * Use EVG distro system uv binaries (#1464) * CXX-3352 Revert "CXX-1885 add NPS survey code" (#1466) This reverts commit 3233473. * CXX-3322 remove atlas data lake testing (#1461) * Re-enable distros previously missing system uv binaries (#1472) * Add C++23 to GCC 12+ compile matrix (#1485) * fix: CDRIVER-5710 in validator examples * fix: CDRIVER-5967 with mongo-c-driver<2.0.1 on MacOS * fix: support mongo-c-driver before and after 2.1.2 * Update Invalid URI test for CDRIVER-5983 (#1429) --------- Co-authored-by: Kevin Albertson <[email protected]> Co-authored-by: Connor MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure CSFLE code paths are also covered by our sanitizer task coverage. Dropped shared library tasks due to redundancy (can switch to dropping static instead if preferable; I don't think there's a significant difference). Additionally added some log messages to help discern Catch test output by test executable.