Skip to content

Conversation

@eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Aug 4, 2025

Resolves CXX-3323. Followup to #1429 and #1434.

#1434 already added the corresponding CHANGELOG entry and removed related EVG tasks.

Scans the codebase for all instances of MongoDB Server version checks against a value that corresponds to 4.0 or older and removes them. Most of these are in test code, but there are a few bits of library code as well, such as in mongocxx::v_noabi::collection::_drop() and an obsolete doc comment for mongocxx::v_noabi::result::bulk_write::modified_count().

@eramongodb eramongodb requested a review from kevinAlbs August 4, 2025 15:31
@eramongodb eramongodb self-assigned this Aug 4, 2025
@eramongodb eramongodb requested a review from a team as a code owner August 4, 2025 15:31
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggested additional removals:

  • Calls test_util::newer_than (which may be better named to test_util::equal_or_newer_than) for "4.2" and older.
  • This check for commitQuorum support.

@eramongodb
Copy link
Contributor Author

eramongodb commented Aug 4, 2025

which may be better named to test_util::equal_or_newer_than

Opted for test_util::server_version_is_at_least to match its description:

Returns 'true' if the server version for the default client is at least 'version', returns 'false' otherwise.

@eramongodb eramongodb merged commit 8cd8bdc into mongodb:master Aug 4, 2025
1 of 2 checks passed
@eramongodb eramongodb deleted the cxx-3323 branch August 4, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants