This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Removing extra guidance for Linux lib rename #1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the fix for the simulator dll name was merged with the cloud simulator feature branch, the guidance on renaming the simulator dll for Linux is no longer needed. See #1093 (comment) for context.
Contributor
|
We do have a work around for this now in the main branch, as @swernli points out. However the fact that we still have the runtime library as a @swernli Does leaving this section of the readme in as a breadcrumb for that issue make sense, or should there be a more official issue for this? Or should we just go forward with what we have and not worry about the |
bettinaheim
reviewed
Jul 28, 2021
Contributor
Author
I agree that the inconsistency in naming there is both annoying and problematic. I would prefer to not confuse anyone approaching these instructions for using QIR with unnecessary steps, so I've instead filed microsoft/qsharp-runtime#783 to track the need to fix our weird renaming patterns. |
ScottCarda-MS
approved these changes
Jul 28, 2021
bettinaheim
pushed a commit
that referenced
this pull request
Aug 25, 2021
troels-im
added a commit
that referenced
this pull request
Sep 10, 2021
* Optimization example: revert PR #1100 (#1125) * Use stdin/stdout instead of TCP/IP. (#1118) * Use stdin/stdout instead of TCP/IP. * Update package-lock. Co-authored-by: Ricardo Espinoza <[email protected]> * Add QIR JIT compilation from Python example (#1124) * Add QIR JIT compilation example in Python * Add README to JIT example and update for Windows * Small fix to JIT example README * Fix NuGet instructions on Linux * More fixes for Linux Co-authored-by: bettinaheim <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> * Update Using and Borrowing Syntax (#1099) * Adding new custom simulator example (#1120) * Initial implementation of a simple simulator for QIR. Goal: Implement an example simulator that is easy to understand and maps more or less directly to the theory. Based on the Eigen C++ linear algebra library. Untested, guide to come. * Small tweaks to QIR simulator example * Restructured version of the Simulator example to separate out components. * First portion of QIR Runtime simulator guide * Add second simulator type: trace simulator Move each simulator to its own subdirectory. * Update Simulation example readme with simulator structure and trace simulator implementation * Remove version 1 of the simulation example * Split out TraceSimulator from top-level README and add run instructions * Move headers and libraries into subfolders * Remove version number from example folder name * Add explanation of the full state simulator sample * Remove duplicate information from top-level simulation sample README * Update structure of top-level simulation sample README * Small fixes to top-level simulator readme * Use and update relative links within repo * Small formatting changes to the sample state simulator README * Add more details on including the Eigen library * Apply suggestions from code review Co-authored-by: Chris Granade <[email protected]> * Add copyright header to source files * Use unicode angle brackets for quantum states * Small fixes to top-level README of simulation example * Get QIR Runtime dependencies from NuGet package instead * Add Linux instructions to sample simulators * Better formatting of the Windows/Linux separation * Apply suggestions from code review. * Add notice about Clang requirement to compile sample * Update examples/QIR/Simulation/TraceSimulator/README.md * Update examples/QIR/Simulation/StateSimulator/README.md Co-authored-by: Chris Granade <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> * Fixing memory leak in generated QIR (#1129) * Update Unit Syntax (#1103) * Update Array Syntax (#1135) * Update readme links to runtime repo (#1137) Co-authored-by: dime10 <[email protected]> Co-authored-by: Chris Granade <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: bettinaheim <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> Co-authored-by: Scott Carda <[email protected]>
troels-im
added a commit
that referenced
this pull request
Sep 15, 2021
* Optimization example: revert PR #1100 (#1125) * Use stdin/stdout instead of TCP/IP. (#1118) * Use stdin/stdout instead of TCP/IP. * Update package-lock. Co-authored-by: Ricardo Espinoza <[email protected]> * Add QIR JIT compilation from Python example (#1124) * Add QIR JIT compilation example in Python * Add README to JIT example and update for Windows * Small fix to JIT example README * Fix NuGet instructions on Linux * More fixes for Linux Co-authored-by: bettinaheim <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> * Update Using and Borrowing Syntax (#1099) * Adding new custom simulator example (#1120) * Initial implementation of a simple simulator for QIR. Goal: Implement an example simulator that is easy to understand and maps more or less directly to the theory. Based on the Eigen C++ linear algebra library. Untested, guide to come. * Small tweaks to QIR simulator example * Restructured version of the Simulator example to separate out components. * First portion of QIR Runtime simulator guide * Add second simulator type: trace simulator Move each simulator to its own subdirectory. * Update Simulation example readme with simulator structure and trace simulator implementation * Remove version 1 of the simulation example * Split out TraceSimulator from top-level README and add run instructions * Move headers and libraries into subfolders * Remove version number from example folder name * Add explanation of the full state simulator sample * Remove duplicate information from top-level simulation sample README * Update structure of top-level simulation sample README * Small fixes to top-level simulator readme * Use and update relative links within repo * Small formatting changes to the sample state simulator README * Add more details on including the Eigen library * Apply suggestions from code review Co-authored-by: Chris Granade <[email protected]> * Add copyright header to source files * Use unicode angle brackets for quantum states * Small fixes to top-level README of simulation example * Get QIR Runtime dependencies from NuGet package instead * Add Linux instructions to sample simulators * Better formatting of the Windows/Linux separation * Apply suggestions from code review. * Add notice about Clang requirement to compile sample * Update examples/QIR/Simulation/TraceSimulator/README.md * Update examples/QIR/Simulation/StateSimulator/README.md Co-authored-by: Chris Granade <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> * Fixing memory leak in generated QIR (#1129) * Creating module based configuration * Adding configuration modules * More refactoring * Deprecating RuleSet profile * Refactoring * Finishing dump config * Preparing for draft PR * Cleaning * More refactoring * Preparing error logging * Fixing CI * Adding commandline tests * Refactor * Fixing issues * Minor changes * Style fixing * Update Unit Syntax (#1103) * Renaming pass * More refactor * Finalising component registration * Formatting style * Minor refactor * Fixed CI * More tests * Removing example QIR * Update Array Syntax (#1135) * Update readme links to runtime repo (#1137) * Updating test * Updating Phi tests * CI update * Removing garbage * Updating according to requests * Removing garbage * Updating config binder Co-authored-by: dime10 <[email protected]> Co-authored-by: Chris Granade <[email protected]> Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: bettinaheim <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> Co-authored-by: Scott Carda <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the fix for the simulator dll name was merged with the cloud simulator feature branch, the guidance on renaming the simulator dll for Linux is no longer needed. See #1093 (comment) for context.