Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Fullstate simulator library should not be renamed to Winodws-style dll on non-Windows platforms. #783

@swernli

Description

@swernli

Right now logic exists in our build passes that takes the output from the xplat build of the native simulator and renames all the files into the Windows style, Microsoft.Quantum.Simulator.Runtime.dll. This is unnecessary and causes confusion when working on other platforms. We should remove this rename, and then update the .csproj files in this repo such that local development does not take a dependency on the rename happening. For example, this part of Simulators.Dev.props:

<ItemGroup>
<None Include="$(QSimDll)" >
<Link>Microsoft.Quantum.Simulator.Runtime.dll</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Visible>false</Visible>
</None>
</ItemGroup>

Should be updated to not expect the file with the Windows specific naming and instead use the built-in support .NET has for dynamically loading the right platform specific library.

Metadata

Metadata

Assignees

Labels

maintenanceImprove codebase quality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions