Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@dime10
Copy link
Contributor

@dime10 dime10 commented Jul 25, 2021

Added section on how to compile and execute QIR

Contains:

  • getting library and header files
  • adding a C++ driver
  • compiling the program

dime10 added 4 commits July 25, 2021 23:42
Contains:
- getting library and header files
- adding a C++ driver
- compiling the program
- configure runtime library search path
- change dll filename to lib<...>.so
- explicitly link Quantum.Simulator.Runtime library
@dime10 dime10 requested review from bettinaheim and swernli July 26, 2021 15:07
Copy link
Contributor

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file rename guidance can now be removed since we fixed this behavior, but otherwise the guidance looks good.

Comment on lines +429 to +437
(**Linux**) The `Microsoft.Quantum.Qir.*` dynamic libraries will already have the right naming scheme for Clang to use, but the `Microsoft.Quantum.Simulator.Runtime` library needs to be renamed.
The proper name format is `lib<library-name>.so`.

Execute the following command from the project root directory:

```bash
mv build/Microsoft.Quantum.Simulator.Runtime.dll build/libMicrosoft.Quantum.Simulator.Runtime.so
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the merge of the cloud simulator feature branch, we now have a bugfix for this situation (see microsoft/qsharp-runtime@9fa45de#diff-164e9c49ce0f05da64d60ae5cf3063a3e017f67ef74b0ba6bcb0a62f62506595). The simulator library infrastructure will always look for Microsoft.Quantum.Simulator.Runtime.dll first and then fallback to looking for libMicrosoft.Quantum.Simulator.Runtime.so. This means the rename is no longer necessary as of today's release (https://docs.microsoft.com/en-us/azure/quantum/qdk-relnotes#qdk-version-0182107153439). So this section can just be removed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... I accidentally clicked merge on this before you had a chance to respond to this comment. I'll make a quick PR removing this part and add you for review!

@swernli
Copy link
Contributor

swernli commented Jul 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@swernli swernli merged commit 0e4a45c into main Jul 27, 2021
swernli added a commit that referenced this pull request Jul 27, 2021
Since the fix for the simulator dll name was merged with the cloud simulator feature branch, the guidance on renaming the simulator dll for Linux is no longer needed. See #1093 (comment) for context.
swernli added a commit that referenced this pull request Jul 28, 2021
* Removing extra guidance for Linux lib rename

Since the fix for the simulator dll name was merged with the cloud simulator feature branch, the guidance on renaming the simulator dll for Linux is no longer needed. See #1093 (comment) for context.

* Update version number in readme and in csproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants