Integrate main commits into feature/v3 branch. #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eep existing usage possible. (microsoft#133)" (microsoft#138) This reverts commit c24f4fd.
…interfaces. (microsoft#131)" (microsoft#139) This reverts commit 7e2a15d.
…icrosoft#140) * Added option to throw for missing features. * Add default value documentation for feature management options.
* Make FeatureManagementSnapshot thread safe. * Add feature manager snapshot concurrency test. * Remove lazy usage.
…gumentNullException when the alias param is null or empty. (microsoft#146)
…rom being evaluated. (microsoft#143)" (microsoft#147) This reverts commit 4231727.
NextDouble() ∈ [0, 1). We use a strict inequality, so a 0% value sporadically returns true as 0⩽0. The fix is to use a non-strict inequality, <. The upper bound still works: 0.999... < 1.
Member
Author
|
cc @avanigupta @zhenlan are you able to take a look at this? |
zhenlan
reviewed
Feb 26, 2022
zhenlan
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main branch had the following commits that need to be integrated into the feature/v3 branch:
These commits should be integrated into the feature/v3 branch before we promote feature/v3 to main.