Skip to content

Conversation

@jimmyca15
Copy link
Member

@jimmyca15 jimmyca15 commented Sep 13, 2021

This PR adds an enhancement to define features with feature filters that should not be evaluated.

There are times when developers configure feature filters for a feature but they do not want this feature to be on. This could be pre-emptive configuration of a feature to include feature filters that is later turned on. Or it could be that a feature is frequently turned off/on but there is a desire to preserve the configuration of filters.

Here is an example feature that has a feature filter registered, but should not be evaluated.

{
  "FeatureManagement": {
    "NonEvaluatedFeature": {
      "Evaluate": false,
      "EnabledFor": [
        {
          "Name": "MyFeatureFilter"
        }
      ]
    }
  }
}

For this feature, await IsEnabledAsync("NonEvaluatedFeature") will return false.

@jimmyca15 jimmyca15 merged commit 4231727 into microsoft:main Sep 20, 2021
jimmyca15 added a commit that referenced this pull request Sep 20, 2021
jimmyca15 added a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants