Skip to content

Conversation

@jimmyca15
Copy link
Member

Updated version to 2.4.0.

<PropertyGroup>
<MajorVersion>2</MajorVersion>
<MinorVersion>3</MinorVersion>
<MinorVersion>4</MinorVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only update the base package version and release that first. Once Microsoft.FeatureManagement v2.4.0 is on NuGet, we can bump up the version of AspNetCore project and also update the base package reference at the same time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AspNetCore project does not reference the base project by package version.

<ProjectReference Include="..\Microsoft.FeatureManagement\Microsoft.FeatureManagement.csproj" />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current setup, both packages are built as v2.4.0 and the aspnet core package declares a reference to 2.4.0 of the base package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit different than the setup in AppConfiguration-DotNetProvider which I believe has the setup it does for some historical reasons, but maybe we could even simplify that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, in that case we don't need separate version upgrades because AspNetCore project has a reference to the base project directly.
For DotNetProvider, we need two different version upgrades because AspNetCore project references the latest base package from NuGet.

@jimmyca15 jimmyca15 merged commit 8d1774f into microsoft:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants