Skip to content

Updated version to 2.4.0. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
+2 −2
Merged

Updated version to 2.4.0. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.FeatureManagement.AspNetCore/Microsoft.FeatureManagement.AspNetCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- Official Version -->
<PropertyGroup>
<MajorVersion>2</MajorVersion>
<MinorVersion>3</MinorVersion>
<MinorVersion>4</MinorVersion>
Copy link
Member

@avanigupta avanigupta Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only update the base package version and release that first. Once Microsoft.FeatureManagement v2.4.0 is on NuGet, we can bump up the version of AspNetCore project and also update the base package reference at the same time.

Copy link
Member Author

@jimmyca15 jimmyca15 Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that?

Copy link
Member Author

@jimmyca15 jimmyca15 Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AspNetCore project does not reference the base project by package version.

FeatureManagement-Dotnet/src/Microsoft.FeatureManagement.AspNetCore/Microsoft.FeatureManagement.AspNetCore.csproj

Line 33 in 423501a

<ProjectReference Include="..\Microsoft.FeatureManagement\Microsoft.FeatureManagement.csproj" />

Copy link
Member Author

@jimmyca15 jimmyca15 Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current setup, both packages are built as v2.4.0 and the aspnet core package declares a reference to 2.4.0 of the base package.

Copy link
Member Author

@jimmyca15 jimmyca15 Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit different than the setup in AppConfiguration-DotNetProvider which I believe has the setup it does for some historical reasons, but maybe we could even simplify that.

Copy link
Member

@avanigupta avanigupta Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, in that case we don't need separate version upgrades because AspNetCore project has a reference to the base project directly.
For DotNetProvider, we need two different version upgrades because AspNetCore project references the latest base package from NuGet.

<PatchVersion>0</PatchVersion>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.FeatureManagement/Microsoft.FeatureManagement.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- Official Version -->
<PropertyGroup>
<MajorVersion>2</MajorVersion>
<MinorVersion>3</MinorVersion>
<MinorVersion>4</MinorVersion>
<PatchVersion>0</PatchVersion>
</PropertyGroup>

Expand Down