Added MessageResponse DTO and added the ability to set response objects #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@CoolGoose do you have any issue with my implementation? If there aren't any i will look to add tests. |
Contributor
|
Hey @JohnstonCode , thank you for the PR, this is looking good for me. |
JohnstonCode
commented
Apr 20, 2021
| parent::loadFromArray($object); | ||
|
|
||
| $this->recipients = (new Recipients())->loadFromArray($this->recipients); | ||
| $this->typeDetails = get_object_vars($this->typeDetails); |
Contributor
Author
There was a problem hiding this comment.
The current implementation returns $typeDetails as a stdClass when its type is set to array
Contributor
|
Great, thank you 🙇 |
CoolGoose
pushed a commit
that referenced
this pull request
Jan 8, 2023
Use MessageReponse mapper instead of Message when calling list endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #127