Use MessageReponse mapper instead of Message when calling list endpoint #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Message mapper is missing the `id` and `href` properties since that mapper is used to map requests. We were still using the Message mapper in the list endpoint which resulted in those properties being removed from the response.
CoolGoose
approved these changes
Jan 6, 2023
Contributor
Author
|
Thanks @CoolGoose. I do not have merging powers so feel free to do so when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Message mapper is missing the
idandhrefproperties since that mapper is used to map requests. We were still using the Message mapper in the list endpoint which resulted in those properties being removed from the response.