Added getRecipients to Message #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Let me know if you would prefer a PR with breaking changes |
Contributor
|
@JohnstonCode I know it's very late, but if you can open a PR with breaking changes since we're targeting 2.x now it would be great. If not i'll cleanup work on merging |
Contributor
Author
|
Do you have a preferred way of solving the |
Contributor
|
@JohnstonCode no. A MessageResponse DTO sounds fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #125 i have made some changes to how the
Recipientsare modelled.I did overlook that the same Message object is used for sending and receiving. This make using the
Message::$recipientsfield difficult as its expecting an array of strings or integers when sending a message. But when it gets a response this is then an array of stdClass...This is the best i could come up with in a non BC breaking manager. It is poor. A better approach would be to have a
MessageResponseclass or similar. Also while making breaking changes it would be nice to parse datatime strings intoDataTimeclasses