Skip to content

Conversation

@webkul-ratnesh
Copy link
Contributor

Description (*)

While editing wishlist item that has configuration, it will not visible selected on configuration page. But after applying this fix it will work.

Fixed Issues (if relevant)

  1. Magento 2.2.6 Default values are not rendering on Wishlist product edit page. #18555: Magento 2.2.6 Default values are not rendering on Wishlist product edit page

Manual testing scenarios (*)

  1. Add any configurable product with configured attributes to wishlist
  2. Now edit the item from wishlist to change the configuration.
  3. On Item configuration page the previously opted option will get selected automatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @webkul-ratnesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Oct 31, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3344 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @webkul-ratnesh. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants