Skip to content

Conversation

@gelanivishal
Copy link
Contributor

Original Pull Request

#18967

Description (*)

While editing wishlist item that has configuration, it will not visible selected on configuration page. But after applying this fix it will work.

Fixed Issues (if relevant)

  1. Magento 2.2.6 Default values are not rendering on Wishlist product edit page. #18555: Magento 2.2.6 Default values are not rendering on Wishlist product edit page

Manual testing scenarios (*)

  1. Add any configurable product with configured attributes to wishlist
  2. Now edit the item from wishlist to change the configuration.
  3. On Item configuration page the previously opted option will get selected automatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3362 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Nov 9, 2018

Hi @gelanivishal , provided fix doesn't solve the problem.

Steps to reproduce:

  1. Change "Color" product attribute type to Visual Swatch.
  2. Create a Configurable Product with 2 options (e. g. 'Red' and 'Blue').
  3. Log in as a Customer, open Configurable Product page and add it's variation (e. g. 'Blue') to Wishlist.
  4. Open Wishlist, find added item, click 'Edit' link.

Selected in 3rd step option(e. g. 'Blue') should be autoselected.

@sivaschenko
Copy link
Member

Hi @gelanivishal , would you like to continue work on this PR?

@sivaschenko
Copy link
Member

@gelanivishal closing due to inactivity. Feel free to contact me if you'd like to continue work on this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants