Skip to content

Conversation

@edenduong
Copy link
Contributor

Original Pull Request

#18967

Description (*)

While editing wishlist item that has configuration, it will not visible selected on configuration page. But after applying this fix it will work.

Fixed Issues (if relevant)

  1. Magento 2.2.6 Default values are not rendering on Wishlist product edit page. #18555: Magento 2.2.6 Default values are not rendering on Wishlist product edit page

Manual testing scenarios (*)

  1. Add any configurable product with configured attributes to wishlist
  2. Now edit the item from wishlist to change the configuration.
  3. On Item configuration page the previously opted option will get selected automatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 23, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@edenduong edenduong changed the title [Forwardport] fixed - Magento 2.2.6 Default values are not rendering on Wishlist product edit page [Forwardport] fixed - Default values are not rendering on Wishlist product edit page Jul 23, 2019
@rodrigowebjump rodrigowebjump self-requested a review July 26, 2019 15:28
@rodrigowebjump
Copy link
Member

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-23838.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rodrigowebjump
Copy link
Member

Hi @edenduong Thanks for your contribution.

The issue still happening for visual or text swatch.
Please, could you test it again?

@ghost ghost assigned sidolov Aug 7, 2019
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, verify issue once again. See @rodrigowebjump comment

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5556 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@edenduong
Copy link
Contributor Author

I close this Pull Request because seems the origin solution has problem. So this Port Pull Request has the same.

@edenduong edenduong closed this Aug 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 9, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants