Skip to content

Conversation

@KarlDeux
Copy link

@KarlDeux KarlDeux commented Jan 23, 2018

Description

Inclusion of indexes into timestamp field in order to avoid deadlocks while on erasing old records.

Fixed Issues (if relevant)

  1. Deadlock occurs using REST API & OAuth 1.0a under high concurrency  #10346: Deadlock occurs using REST API & OAuth 1.0a under high concurrency

Manual testing scenarios

  1. Pull the code and run php bin/magento setup:upgrade
  2. Create thousands of OAuth 1.0a requests to REST API (eg concurrency of 5 / sec)
  3. Requests should complete successfully

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Jan 24, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 24, 2018
@okorshenko okorshenko modified the milestones: January 2018, February 2018 Feb 7, 2018
@okorshenko okorshenko modified the milestones: February 2018, March 2018 Mar 1, 2018
@dmanners
Copy link
Contributor

dmanners commented Mar 8, 2018

Hi @KarlDeux we are looking to get a test case sorted for this. Would you be able to help us out. #10346 (comment)

@KarlDeux
Copy link
Author

Hi @dmanners, just replied to the comment.
Sorry for the late response, It's been some crazily busy days.

@dmanners
Copy link
Contributor

No worries @KarlDeux thanks for getting back to us on this.

@magento-engcom-team
Copy link
Contributor

Hi @KarlDeux. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants