Skip to content

Conversation

@gelanivishal
Copy link
Contributor

Original Pull Request

#13328

Description

Inclusion of indexes into timestamp field in order to avoid deadlocks while on erasing old records.

Fixed Issues (if relevant)

  1. Deadlock occurs using REST API & OAuth 1.0a under high concurrency  #10346: Deadlock occurs using REST API & OAuth 1.0a under high concurrency

Manual testing scenarios

  1. Pull the code and run php bin/magento setup:upgrade
  2. Create thousands of OAuth 1.0a requests to REST API (eg concurrency of 5 / sec)
  3. Requests should complete successfully

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2163 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Jul 5, 2018

Hi @gelanivishal , unfortunately, we can't accept this pull request due to Backward incompatible changes, please, refer to Backward Compatible Develompent Guide for more information.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants