Skip to content

Conversation

@rogyar
Copy link
Contributor

@rogyar rogyar commented Jul 11, 2018

Original PR: #13328

Description

Inclusion of indexes into timestamp field in order to avoid deadlocks while on erasing old records.

Fixed Issues (if relevant)

  1. Deadlock occurs using REST API & OAuth 1.0a under high concurrency  #10346: Deadlock occurs using REST API & OAuth 1.0a under high concurrency

Manual testing scenarios

  1. Pull the code and run php bin/magento setup:upgrade
  2. Create thousands of OAuth 1.0a requests to REST API (eg concurrency of 5 / sec)
  3. Requests should complete successfully

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar added Release Line: 2.3 Back port/Up port Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner and removed Component: Integration Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 11, 2018
@orlangur orlangur self-assigned this Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2279 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Integration Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants