Skip to content

Conversation

@pmclain
Copy link
Contributor

@pmclain pmclain commented Nov 4, 2020

Description (*)
Backport #386

This commit adjusts the editable theme filter to only exclued composer
themes in vendor/magento. All other themes installed via composer will
appear in the theme list when using the "Override this template in a
project theme" action.

Fixed Issues (if relevant)

  1. Fixes Action/Code Generation. Override view file in a custom theme #64

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

fixes magento#64

This commit adjusts the editable theme filter to only exclued composer
themes in `vendor/magento`. All other themes installed via composer will
appear in the theme list when using the "Override this template in a
project theme" action.
Copy link
Contributor

@coderimus coderimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the backport @pmclain 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants